lp1801947 eg-help-popover accessibility
authorMike Risher <mrisher@catalyte.io>
Fri, 19 Jun 2020 20:00:04 +0000 (20:00 +0000)
committerJane Sandberg <sandbej@linnbenton.edu>
Mon, 17 Aug 2020 20:50:00 +0000 (13:50 -0700)
Modify the eg-help-popover directive so that it can be invoked via
a keyboard action.

Signed-off-by: Mike Risher <mrisher@catalyte.io>
 Changes to be committed:
modified:   Open-ILS/src/templates/staff/css/style.css.tt2
modified:   Open-ILS/src/templates/staff/share/t_help_popover.tt2

Signed-off-by: Terran McCanna <tmccanna@georgialibraries.org>
Signed-off-by: Jane Sandberg <sandbej@linnbenton.edu>
Open-ILS/src/templates/staff/css/style.css.tt2
Open-ILS/src/templates/staff/share/t_help_popover.tt2

index 684cf3d..02c949b 100644 (file)
@@ -202,6 +202,9 @@ table.list tr.selected td { /* deprecated? */
    e.g., a item alert */
 .acknowledged { text-decoration: line-through; }
 
+/* eg-help-popover directive doesn't need a border around its <button> */
+.no-border.glyphicon-question-sign { border-color: #fff; }
+
 /* bootstrap alerts are heavily padded.  use this to reduce */
 .alert-less-pad {padding: 5px;}
 
index c07ee20..6ce1e4a 100644 (file)
@@ -1,12 +1,14 @@
-<span class="glyphicon glyphicon-question-sign"
+<button class="glyphicon glyphicon-question-sign no-border"
       uib-popover="{{helpText}}"
       popover-trigger="click"
       popover-placement="auto"
+      i18n-aria-label aria-label="Help"
       ng-if="!helpLink || helpLink.length == 0"
-></span>
-<span class="glyphicon glyphicon-question-sign"
+></button>
+<button class="glyphicon glyphicon-question-sign no-border"
       uib-popover-html="helpHtml"
       popover-trigger="click"
       popover-placement="auto"
+      i18n-aria-label aria-label="Help"
       ng-if="helpLink.length > 0"
-></span>
+></button>