Repaired copy private/public note vandelay bug

Previously, all copy notes imported through vandelay were coming in as
public copy notes.

Signed-off-by: Bill Erickson <berick@esilibrary.com>
Signed-off-by: Lebbeous Fogle-Weekley <lebbeous@esilibrary.com>

diff --git a/Open-ILS/src/perlmods/lib/OpenILS/Application/Cat/AssetCommon.pm b/Open-ILS/src/perlmods/lib/OpenILS/Application/Cat/AssetCommon.pm
index 11ecdfc..626a9a1 100644 (file)
--- a/Open-ILS/src/perlmods/lib/OpenILS/Application/Cat/AssetCommon.pm
+++ b/Open-ILS/src/perlmods/lib/OpenILS/Application/Cat/AssetCommon.pm
@@ -523,7 +523,7 @@ sub create_copy_note {
     my $note = Fieldmapper::asset::copy_note->new;
     $note->owning_copy($copy->id);
     $note->creator($e->requestor->id);
-    $note->pub('t');
+    $note->pub($pub ? 't' : 'f');
     $note->value($value);
     $note->title($title);
     $e->create_asset_copy_note($note) or return $e->die_event;

diff --git a/Open-ILS/src/perlmods/lib/OpenILS/Application/Vandelay.pm b/Open-ILS/src/perlmods/lib/OpenILS/Application/Vandelay.pm
index c2811d1..78c6f38 100644 (file)
--- a/Open-ILS/src/perlmods/lib/OpenILS/Application/Vandelay.pm
+++ b/Open-ILS/src/perlmods/lib/OpenILS/Application/Vandelay.pm
@@ -1543,7 +1543,7 @@ sub import_record_asset_list_impl {
             }
 
             $evt = OpenILS::Application::Cat::AssetCommon->create_copy_note(
-                $e, $copy, '', $item->priv_note, 1) if $item->priv_note;
+                $e, $copy, '', $item->priv_note) if $item->priv_note;
 
             if($evt) {
                 $$report_args{evt} = $evt;