LP#1086458: remove unecessary anonymous hashes when calling xulG.set_tab()
authorGalen Charlton <gmc@esilibrary.com>
Mon, 14 Oct 2013 16:21:58 +0000 (09:21 -0700)
committerDan Wells <dbw2@calvin.edu>
Tue, 15 Oct 2013 20:46:10 +0000 (16:46 -0400)
This follows up on observations made by Steven Chan that
suggests that even the act of creating an anonymous hash and
passing it to a global function can cause (I assume) JavaScript
execution contexts to be leaked.

Signed-off-by: Galen Charlton <gmc@esilibrary.com>
Signed-off-by: Dan Wells <dbw2@calvin.edu>
Open-ILS/xul/staff_client/chrome/content/main/menu.js

index 37d92aa..4d923c2 100644 (file)
@@ -1784,7 +1784,7 @@ main.menu.prototype = {
             'refresh_checkout',
             function() {
                 try {
-                    obj.set_tab(obj.url_prefix('XUL_PATRON_BARCODE_ENTRY'),{},{});
+                    obj.set_tab(obj.url_prefix('XUL_PATRON_BARCODE_ENTRY'));
                 } catch(E) {
                     obj.error.sdump('D_ERROR','tab_refresh_checkout_handler: ' + js2JSON(E));
                 }