my $badges = '';
my ($badge_filter) = $self->find_filter('badges');
if ($badge_filter && @{$badge_filter->args}) {
- $badges = join (',', grep /^\d+$/ @{$badge_filter->args});
+ $badges = join (',', grep /^\d+$/, @{$badge_filter->args});
}
# Do we have a badge_orgs() filter? (used for calculating popularity)
my $borgs = '';
my ($bo_filter) = $self->find_filter('badge_orgs');
if ($bo_filter && @{$bo_filter->args}) {
- my $borgs = join (',', grep /^\d+$/ @{$bo_filter->args});
+ my $borgs = join (',', grep /^\d+$/, @{$bo_filter->args});
}
# Build the badge-ish WITH query
if (@lg_id_list) {
my @borg_list;
- for my $lg ( grep { /^\d+$/ } @lg_id_list} ) {
+ for my $lg ( grep { /^\d+$/ } @lg_id_list ) {
my $lg_obj = asset::copy_location_group->retrieve($lg);
next unless $lg_obj;
$site = actor::org_unit->search( { shortname => $args{org_unit} })->next unless ($site);
}
- if ($site && $site->id <> $top_org->id) {
+ if ($site && $site->id != $top_org->id) {
my ($depth_filter) = $base_plan->parse_tree->find_filter('depth');
my $depth = $depth_filter->args->[0] if ($depth_filter && $depth_filter->args->[0] =~ /^\d+$/);
$depth = $args{depth} if (!defined($depth) && defined($args{depth}) && $args{depth} =~ /^\d+$/);
if ($self->cgi->param('badges')) {
my $badges = $self->cgi->param('badges');
$badges = $badges ? split(',', $badges) : [];
- $badges = [grep { /^\d+$/ } @$badges]
+ $badges = [grep { /^\d+$/ } @$badges];
if (@$badges) {
$self->ctx->{badge_scores} = $cstore->request(
'open-ils.cstore.direct.rating.record_badge_score.search.atomic',
my $badges = $self->editor->search_rating_badge(
{ id => { '!=' => undef } }
- ]);
+ );
if (@$badges) {
my %badge_hash = map {($_->id => $_)} @$badges;