LP#1549505: fix Perl syntax error
authorGalen Charlton <gmc@esilibrary.com>
Thu, 4 Feb 2016 20:16:00 +0000 (15:16 -0500)
committerGalen Charlton <gmc@esilibrary.com>
Wed, 24 Feb 2016 22:39:41 +0000 (17:39 -0500)
Signed-off-by: Galen Charlton <gmc@esilibrary.com>
Open-ILS/src/perlmods/lib/OpenILS/Application/Storage/Driver/Pg/QueryParser.pm
Open-ILS/src/perlmods/lib/OpenILS/Application/Storage/Publisher/metabib.pm
Open-ILS/src/perlmods/lib/OpenILS/WWW/EGCatLoader/Record.pm
Open-ILS/src/perlmods/lib/OpenILS/WWW/EGCatLoader/Util.pm

index 3ac53e1..6d09728 100644 (file)
@@ -836,14 +836,14 @@ sub toSQL {
     my $badges = '';
     my ($badge_filter) = $self->find_filter('badges');
     if ($badge_filter && @{$badge_filter->args}) {
-        $badges = join (',', grep /^\d+$/ @{$badge_filter->args});
+        $badges = join (',', grep /^\d+$/, @{$badge_filter->args});
     }
 
     # Do we have a badge_orgs() filter? (used for calculating popularity)
     my $borgs = '';
     my ($bo_filter) = $self->find_filter('badge_orgs');
     if ($bo_filter && @{$bo_filter->args}) {
-        my $borgs = join (',', grep /^\d+$/ @{$bo_filter->args});
+        my $borgs = join (',', grep /^\d+$/, @{$bo_filter->args});
     }
 
     # Build the badge-ish WITH query
index f30b4d9..6786d4e 100644 (file)
@@ -3160,7 +3160,7 @@ sub query_parser_fts_wrapper {
 
     if (@lg_id_list) {
         my @borg_list;
-        for my $lg ( grep { /^\d+$/ } @lg_id_list} ) {
+        for my $lg ( grep { /^\d+$/ } @lg_id_list ) {
             my $lg_obj = asset::copy_location_group->retrieve($lg);
             next unless $lg_obj;
 
@@ -3187,7 +3187,7 @@ sub query_parser_fts_wrapper {
             $site = actor::org_unit->search( { shortname => $args{org_unit} })->next unless ($site);
         }
     
-        if ($site && $site->id <> $top_org->id) {
+        if ($site && $site->id != $top_org->id) {
             my ($depth_filter) = $base_plan->parse_tree->find_filter('depth');
             my $depth = $depth_filter->args->[0] if ($depth_filter && $depth_filter->args->[0] =~ /^\d+$/);
             $depth = $args{depth} if (!defined($depth) && defined($args{depth}) && $args{depth} =~ /^\d+$/);
index 719fc56..ac3783a 100644 (file)
@@ -69,7 +69,7 @@ sub load_record {
     if ($self->cgi->param('badges')) {
         my $badges = $self->cgi->param('badges');
         $badges = $badges ? split(',', $badges) : [];
-        $badges = [grep { /^\d+$/ } @$badges]
+        $badges = [grep { /^\d+$/ } @$badges];
         if (@$badges) {
             $self->ctx->{badge_scores} = $cstore->request(
                 'open-ils.cstore.direct.rating.record_badge_score.search.atomic',
index a6aca7d..f34398d 100644 (file)
@@ -683,7 +683,7 @@ sub load_badges {
 
     my $badges = $self->editor->search_rating_badge(
         { id => { '!=' => undef } }
-    ]);
+    );
 
     if (@$badges) {
         my %badge_hash = map {($_->id => $_)} @$badges;