Don't check barcode without strict enabled
authorThomas Berezansky <tsbere@mvlc.org>
Thu, 22 Sep 2011 13:16:31 +0000 (09:16 -0400)
committerMike Rylander <mrylander@gmail.com>
Tue, 15 Nov 2011 20:01:04 +0000 (15:01 -0500)
Item status was, unlike other interfaces, doing the strict check, THEN
looking at the checkbox and if it was checked return.

This caused issues when the barcode crashes out the strict checking.

Signed-off-by: Thomas Berezansky <tsbere@mvlc.org>
Signed-off-by: Mike Rylander <mrylander@gmail.com>
Open-ILS/xul/staff_client/server/circ/copy_status.js

index 510d13c..89e6287 100644 (file)
@@ -1107,9 +1107,9 @@ circ.copy_status.prototype = {
 
     'test_barcode' : function(bc) {
         var obj = this;
-        var good = util.barcode.check(bc);
         var x = document.getElementById('strict_barcode');
         if (x && x.checked != true) { return true; }
+        var good = util.barcode.check(bc);
         if (good) {
             return true;
         } else {