projects / Evergreen.git / commitdiff
? search:
summary | shortlog | log | commit | commitdiff | tree
raw | patch | inline | side by side (parent: e28ef5d)
replace parseInt with Number to prevent octal interpretation
authorphasefx <phasefx@dcc99617-32d9-48b4-a31d-7c20da2025e4>
Fri, 4 Aug 2006 06:12:49 +0000 (06:12 +0000)
committerphasefx <phasefx@dcc99617-32d9-48b4-a31d-7c20da2025e4>
Fri, 4 Aug 2006 06:12:49 +0000 (06:12 +0000)
git-svn-id: svn://svn.open-ils.org/ILS/trunk@5281 dcc99617-32d9-48b4-a31d-7c20da2025e4

Open-ILS/xul/staff_client/server/cat/spine_labels.xul patch | blob | history
Open-ILS/xul/staff_client/server/cat/volume_copy_creator.js patch | blob | history
Open-ILS/xul/staff_client/server/circ/checkout.js patch | blob | history
Open-ILS/xul/staff_client/server/circ/in_house_use.js patch | blob | history
Open-ILS/xul/staff_client/server/circ/util.js patch | blob | history
Open-ILS/xul/staff_client/server/patron/util.js patch | blob | history

diff --git a/Open-ILS/xul/staff_client/server/cat/spine_labels.xul b/Open-ILS/xul/staff_client/server/cat/spine_labels.xul
index 62930dd..c5c686f 100644 (file)
--- a/Open-ILS/xul/staff_client/server/cat/spine_labels.xul
+++ b/Open-ILS/xul/staff_client/server/cat/spine_labels.xul
@@ -79,8 +79,8 @@
                function generate() {
                        try {
                                JSAN.use('util.widgets'); util.widgets.remove_children('panel'); var pn = $('panel'); $('preview').disabled = false;
-                               var lw = parseInt($('lw').value) || 8;
-                               var ll = parseInt($('ll').value) || 9;
+                               var lw = Number($('lw').value) || 8;
+                               var ll = Number($('ll').value) || 9;
                                for (var i in g.volumes) {
                                        var hb = document.createElement('vbox'); pn.appendChild(hb); hb.setAttribute('name','template');
                                        var ds = document.createElement('description'); hb.appendChild(ds);
@@ -129,15 +129,15 @@
                function preview() {
                        try {
                                        netscape.security.PrivilegeManager.enablePrivilege('UniversalXPConnect');
-                                       var pt = parseInt( $('pt').value ) || 10; var lm = parseInt($('lm').value); if (lm == NaN) lm = 11;
-                                       var lw = parseInt($('lw').value) || 8; var ll = parseInt($('ll').value) || 9; 
-                                       var sbl = parseInt($('sbl').value); if (sbl == NaN) sbl = 2;
+                                       var pt = Number( $('pt').value ) || 10; var lm = Number($('lm').value); if (lm == NaN) lm = 11;
+                                       var lw = Number($('lw').value) || 8; var ll = Number($('ll').value) || 9; 
+                                       var sbl = Number($('sbl').value); if (sbl == NaN) sbl = 2;
                                        //alert('pt = ' + pt + ' lm = ' + lm + ' lw = ' + lw + ' ll = ' + ll + ' sbl = ' + sbl);
                                        var html = "<html><head><link type='text/css' rel='stylesheet' href='data:text/css,pre{font-size:" + pt;
                                        html += "pt}'></link><title>Spine Labels</title></head><body><pre>\n";
                                        var nl = document.getElementsByAttribute('name','template');
                                        for (var i = 0; i < nl.length; i++) {
-                                               var count = parseInt( nl[i].getElementsByAttribute('name','count')[0].value ); if (count == NaN) count = 1;
+                                               var count = Number( nl[i].getElementsByAttribute('name','count')[0].value ); if (count == NaN) count = 1;
                                                for (var j = 0; j < count; j++) {
                                                        var gb = nl[i].childNodes[1];
                                                        var nl2 = gb.getElementsByTagName('textbox');
diff --git a/Open-ILS/xul/staff_client/server/cat/volume_copy_creator.js b/Open-ILS/xul/staff_client/server/cat/volume_copy_creator.js
index bfdac19..d1e4b06 100644 (file)
--- a/Open-ILS/xul/staff_client/server/cat/volume_copy_creator.js
+++ b/Open-ILS/xul/staff_client/server/cat/volume_copy_creator.js
@@ -122,7 +122,7 @@ g.render_volume_count_entry = function(row,ou_id) {
        var node;
        function render_copy_count_entry(ev) {
                if (ev.target.disabled) return;
-               if (! isNaN( parseInt( ev.target.value) ) ) {
+               if (! isNaN( Number( ev.target.value) ) ) {
                        if (node) { row.removeChild(node); node = null; }
                        //ev.target.disabled = true;
                        node = g.render_callnumber_copy_count_entry(row,ou_id,ev.target.value);
@@ -168,7 +168,7 @@ g.render_callnumber_copy_count_entry = function(row,ou_id,count) {
 
        function handle_change(tb1,tb2,hb3) {
                if (tb1.value == '') return;
-               if (isNaN( parseInt( tb2.value ) )) return;
+               if (isNaN( Number( tb2.value ) )) return;
 
                //if (tb1.disabled || tb2.disabled) return;
 
@@ -177,7 +177,7 @@ g.render_callnumber_copy_count_entry = function(row,ou_id,count) {
 
                util.widgets.remove_children(hb3);
 
-               g.render_barcode_entry(hb3,tb1.value,parseInt(tb2.value),ou_id);
+               g.render_barcode_entry(hb3,tb1.value,Number(tb2.value),ou_id);
                document.getElementById("Create").disabled = false;
        }
 
diff --git a/Open-ILS/xul/staff_client/server/circ/checkout.js b/Open-ILS/xul/staff_client/server/circ/checkout.js
index 07b0910..a24b8a0 100644 (file)
--- a/Open-ILS/xul/staff_client/server/circ/checkout.js
+++ b/Open-ILS/xul/staff_client/server/circ/checkout.js
@@ -124,7 +124,7 @@ circ.checkout.prototype = {
                                                                netscape.security.PrivilegeManager.enablePrivilege('UniversalXPConnect UniversalBrowserWrite');
                                                                var r = window.prompt('Enter the number of ' + obj.data.hash.cnct[ params.noncat_type].name() + ' circulating:','1','Non-cataloged Items');
                                                                if (r) {
-                                                                       count = parseInt(r);
+                                                                       count = Number(r);
                                                                        if (count > 0) {
                                                                                if (count > 99) {
                                                                                        obj.error.yns_alert('You tried to circulate ' + count + ' ' + obj.data.hash.cnct[ params.noncat_type].name() + '.  The maximum is 99 per action.','Non-cataloged Circulation','OK',null,null,'Check here to confirm this message.');
diff --git a/Open-ILS/xul/staff_client/server/circ/in_house_use.js b/Open-ILS/xul/staff_client/server/circ/in_house_use.js
index 36ec954..c04ea57 100644 (file)
--- a/Open-ILS/xul/staff_client/server/circ/in_house_use.js
+++ b/Open-ILS/xul/staff_client/server/circ/in_house_use.js
@@ -61,7 +61,7 @@ circ.in_house_use.prototype = {
                                                function(ev) {
                                                        if (ev.target.nodeName == 'textbox') {
                                                                try {
-                                                                       var value = parseInt(ev.target.value);
+                                                                       var value = Number(ev.target.value);
                                                                        if (value > 0) {
                                                                                if (value > 99) ev.target.value = 99;
                                                                        } else {
@@ -134,7 +134,7 @@ circ.in_house_use.prototype = {
                var obj = this;
                try {
                        var barcode = obj.controller.view.in_house_use_barcode_entry_textbox.value;
-                       var multiplier = parseInt( obj.controller.view.in_house_use_multiplier_textbox.value );
+                       var multiplier = Number( obj.controller.view.in_house_use_multiplier_textbox.value );
 
                        if (barcode == '') {
                                obj.controller.view.in_house_use_barcode_entry_textbox.focus();
diff --git a/Open-ILS/xul/staff_client/server/circ/util.js b/Open-ILS/xul/staff_client/server/circ/util.js
index 9eb279b..fc88fc7 100644 (file)
--- a/Open-ILS/xul/staff_client/server/circ/util.js
+++ b/Open-ILS/xul/staff_client/server/circ/util.js
@@ -895,7 +895,7 @@ circ.util.hold_capture_via_copy_barcode = function ( session, barcode, retrieve_
                check.text = robj.textcode;
                check.route_to = robj.route_to;
                //check.text = 'Captured for Hold';
-               if (parseInt(check.route_to)) check.route_to = data.hash.aou[ check.route_to ].shortname();
+               if (Number(check.route_to)) check.route_to = data.hash.aou[ check.route_to ].shortname();
                return check;
        } catch(E) {
                JSAN.use('util.error'); var error = new util.error();
diff --git a/Open-ILS/xul/staff_client/server/patron/util.js b/Open-ILS/xul/staff_client/server/patron/util.js
index 8c86fc2..f0f38ef 100644 (file)
--- a/Open-ILS/xul/staff_client/server/patron/util.js
+++ b/Open-ILS/xul/staff_client/server/patron/util.js
@@ -477,7 +477,7 @@ patron.util.set_penalty_css = function(patron) {
                        born = born.getTime()/1000
 
                        var patron_age = now - born;
-                       var years_old = parseInt(patron_age / TIME.year);
+                       var years_old = Number(patron_age / TIME.year);
 
                        addCSSClass(document.documentElement,'PATRON_AGE_IS_' + years_old);
 
Evergreen ILS