making old_best tests more explicit

git-svn-id: svn://svn.open-ils.org/ILS/branches/rel_1_2@9003 dcc99617-32d9-48b4-a31d-7c20da2025e4

diff --git a/Open-ILS/src/perlmods/OpenILS/Application/Storage/Publisher/action.pm b/Open-ILS/src/perlmods/OpenILS/Application/Storage/Publisher/action.pm
index 2d1e075..3a83aa4 100644 (file)
--- a/Open-ILS/src/perlmods/OpenILS/Application/Storage/Publisher/action.pm
+++ b/Open-ILS/src/perlmods/OpenILS/Application/Storage/Publisher/action.pm
@@ -919,11 +919,7 @@ sub new_hold_copy_targeter {
        
                        if (!scalar(@good_copies)) {
                                $log->info("\tNo (non-current) copies eligible to fill the hold.");
-                               if (
-                                 $old_best &&
-                                 grep { $old_best eq $_ } @$all_copies &&
-                                 !action::hold_request->search_where({ current_copy => $old_best->id, capture_time => undef, cancel_time => undef })
-                               ) {
+                               if ( $old_best && grep { ''.$old_best->id eq ''.$_->id } @$all_copies ) {
                                        # the old copy is still available
                                        $log->debug("\tPushing current_copy back onto the targeting list");
                                        push @good_copies, $old_best;