LP#1760223: Update HTTP headers to follow standard user/miker/lp-1760223-download-exported-records
authorMike Rylander <mrylander@gmail.com>
Mon, 2 Apr 2018 20:09:12 +0000 (16:09 -0400)
committerMike Rylander <mrylander@gmail.com>
Mon, 2 Apr 2018 20:09:12 +0000 (16:09 -0400)
In the olden days, some browsers didn't understand the "attachment" content
disposition.  They only understood "inline" but would let the user save a file
if a filename was provided.  However, in these modern days, relevant browsers
all do the right thing and know about both flavors of content disposition, so
we, too, must change with the times and support the letter of the standard.

This commit fixes downloading of MARCXML from the Exporter module.

Signed-off-by: Mike Rylander <mrylander@gmail.com>
Open-ILS/src/perlmods/lib/OpenILS/WWW/Exporter.pm

index bf2fa36..8508ab6 100644 (file)
@@ -180,7 +180,7 @@ sub handler {
     }
 
 
-    $r->headers_out->set("Content-Disposition" => "inline; filename=$filename");
+    $r->headers_out->set("Content-Disposition" => "attachment; filename=$filename");
 
     if (uc($format) eq 'XML') {
         $r->content_type('application/xml');