LP#1978889: display alert type for existing item alerts
authorGalen Charlton <gmc@equinoxOLI.org>
Mon, 11 Jul 2022 14:38:47 +0000 (10:38 -0400)
committerBill Erickson <berickxx@gmail.com>
Wed, 27 Jul 2022 20:42:24 +0000 (16:42 -0400)
This patch ensures that the type of an item alert is
displayed when managing item alerts in the Angular item
attributes editor.

To test
-------
[1] Add an alert to an item.
[2] From the Angular Holdings View, chose 'Edit Item Alerts'
    for that item. Note that the combobox for the existing
    alert does not display a value.
[3] Open the item in the Item Attributes editor and click
    the Item Alerts button. Again, note that the alert type
    combobox does not display a value.
[4] Apply the patch and repeat steps 2 and 3. This time, the alert
    type should be displayed.

Signed-off-by: Galen Charlton <gmc@equinoxOLI.org>
Signed-off-by: Bill Erickson <berickxx@gmail.com>
Signed-off-by: Elaine Hardy <ehardy@georgialibraries.org>
Open-ILS/src/eg2/src/app/staff/share/holdings/copy-alerts-dialog.component.html

index 5ccf7ff..db782ad 100644 (file)
@@ -57,9 +57,9 @@
         *ngFor="let alert of copy.copy_alerts()">
         <div class="col-lg-12 pb-2"><hr/></div>
         <div class="col-lg-4">
-          <eg-combobox [entries]="alertTypes" [startId]="alert.alert_type()"
+          <eg-combobox [entries]="alertTypes" [selectedId]="alert.alert_type()"
             i18n-placeholder placeholder="Alert Type..."
-            [required]="true"
+            [mandatory]="true"
             (onChange)="alert.alert_type($event ? $event.id : null); alert.ischanged(true)">
           </eg-combobox>
           <div class="pl-2 pt-2" i18n>