When inside mod_perl, and the client disconnects, stop trying to receive results...
authorMike Rylander <mrylander@gmail.com>
Thu, 4 Aug 2016 12:57:44 +0000 (08:57 -0400)
committerMike Rylander <mrylander@gmail.com>
Thu, 4 Aug 2016 12:57:44 +0000 (08:57 -0400)
Signed-off-by: Mike Rylander <mrylander@gmail.com>
src/perl/lib/OpenSRF/Transport/SlimJabber/XMPPReader.pm

index d1ebfa1..04259e2 100644 (file)
@@ -210,7 +210,31 @@ sub wait {
     my $infile = '';
     vec($infile, $socket->fileno, 1) = 1;
 
-    my $nfound = select($infile, undef, undef, $timeout);
+    my $nfound;
+    if (!$ENV{OSRF_APACHE_REQUEST_OBJ} || $timeout <= 1.0) {
+        $nfound = select($infile, undef, undef, $timeout);
+    } else {
+        $timeout -= 1.0;
+        for (
+            my $sleep = 1.0;
+            $timeout >= 0.0;
+            do {
+                $sleep = $timeout < 1.0 ? $timeout : 1.0;
+                $timeout -= 1.0;
+            }
+        ) {
+            $nfound = select($infile, undef, undef, $sleep);
+            last if $nfound;
+            if (
+                $ENV{OSRF_APACHE_REQUEST_OBJ} &&
+                $ENV{OSRF_APACHE_REQUEST_OBJ}->connection->aborted
+            ) {
+                # Should this be more severe? Die or throw error?
+                $logger->warn("Upstream Apache client disconnected, aborting.");
+                last;
+            };
+        }
+    }
     return undef if !$nfound or $nfound == -1;
 
     # now slurp the data off the socket