don't try to pre-alert for expired holds if the hold doesn't even expire

git-svn-id: svn://svn.open-ils.org/ILS/branches/rel_1_4@12847 dcc99617-32d9-48b4-a31d-7c20da2025e4

diff --git a/Open-ILS/web/opac/skin/default/js/myopac.js b/Open-ILS/web/opac/skin/default/js/myopac.js
index 02f0303..73be5c3 100644 (file)
--- a/Open-ILS/web/opac/skin/default/js/myopac.js
+++ b/Open-ILS/web/opac/skin/default/js/myopac.js
@@ -358,8 +358,9 @@ function myOPACDrawHolds(r) {
 
         $n(row, 'myopac_holds_selected_chkbx').checked = false;
 
+        var exp_date;
         if(h.expire_time()) {
-            var exp_date = dojo.date.stamp.fromISOString(h.expire_time());
+            exp_date = dojo.date.stamp.fromISOString(h.expire_time());
             $n(row, 'myopac_hold_expire_time').appendChild(
                 text(dojo.date.locale.format(exp_date, {selector:'date'})));
         }
@@ -367,7 +368,7 @@ function myOPACDrawHolds(r) {
                unHideMe(row);
 
         var interval = fetchOrgSettingDefault(G.user.home_ou(), 'circ.hold_expire_alert_interval');
-        if(interval) {
+        if(interval && exp_date) {
             secs = interval_to_seconds(interval) * 1000;
             var diff = exp_date.getTime() - new Date().getTime();
             if(diff < secs)