LP1904036 ng lint --fix

Signed-off-by: Bill Erickson <berickxx@gmail.com>
Signed-off-by: Jane Sandberg <js7389@princeton.edu>
Signed-off-by: Galen Charlton <gmc@equinoxOLI.org>

diff --git a/Open-ILS/src/eg2/src/app/share/dialog/prompt.component.html b/Open-ILS/src/eg2/src/app/share/dialog/prompt.component.html
index 1d6df67..7375633 100644 (file)
--- a/Open-ILS/src/eg2/src/app/share/dialog/prompt.component.html
+++ b/Open-ILS/src/eg2/src/app/share/dialog/prompt.component.html
@@ -10,8 +10,8 @@
     <p>{{dialogBody}}</p>
     <div class="text-center">
         <input type="{{promptType}}" class="form-control" id="{{inputDomId}}"
-          [attr.min]="promptType == 'number' ? promptMin : ''"
-          [attr.max]="promptType == 'number' ? promptMax : ''"
+          [attr.min]="promptType === 'number' ? promptMin : ''"
+          [attr.max]="promptType === 'number' ? promptMax : ''"
           (keyup.enter)="close(promptValue)" [(ngModel)]="promptValue"/>
     </div>
   </div>

diff --git a/Open-ILS/src/eg2/src/app/staff/circ/patron/barcodes.component.html b/Open-ILS/src/eg2/src/app/staff/circ/patron/barcodes.component.html
index dd83803..7c69a7b 100644 (file)
--- a/Open-ILS/src/eg2/src/app/staff/circ/patron/barcodes.component.html
+++ b/Open-ILS/src/eg2/src/app/staff/circ/patron/barcodes.component.html
@@ -22,7 +22,7 @@
       <div class="col-lg-4" i18n>
         <input type="checkbox" [disabled]="!myPerms.UPDATE_PATRON_ACTIVE_CARD"
           (ngModelChange)="activeChange(card, $event)"
-          class="form-check-input ml-0" [ngModel]="card.active() == 't'">
+          class="form-check-input ml-0" [ngModel]="card.active() === 't'">
       </div>
       <div class="col-lg-4" i18n>
         <input type="radio" name="primary-card" [value]="card.id()"

diff --git a/Open-ILS/src/eg2/src/app/staff/circ/patron/bill-statement.component.html b/Open-ILS/src/eg2/src/app/staff/circ/patron/bill-statement.component.html
index 227f603..cc06c8f 100644 (file)
--- a/Open-ILS/src/eg2/src/app/staff/circ/patron/bill-statement.component.html
+++ b/Open-ILS/src/eg2/src/app/staff/circ/patron/bill-statement.component.html
@@ -165,8 +165,8 @@
                   <span *ngIf="line.end_date"> - {{line.end_date  | date:'short'}}</span>
                 </div>
               </div>
-              <div class="col-lg-2" [ngClass]="{'text-danger': line.type != 'billing'}">
-                <span *ngIf="line.type != 'billing'">-</span>{{line.amount | currency}}
+              <div class="col-lg-2" [ngClass]="{'text-danger': line.type !== 'billing'}">
+                <span *ngIf="line.type !== 'billing'">-</span>{{line.amount | currency}}
               </div>
               <div class="col-lg-2">{{line.running_balance | currency}}</div>
             </div>

diff --git a/Open-ILS/src/eg2/src/app/staff/circ/patron/edit.component.html b/Open-ILS/src/eg2/src/app/staff/circ/patron/edit.component.html
index 75fcc9e..82dff2d 100644 (file)
--- a/Open-ILS/src/eg2/src/app/staff/circ/patron/edit.component.html
+++ b/Open-ILS/src/eg2/src/app/staff/circ/patron/edit.component.html
@@ -94,7 +94,7 @@
       class="form-check-input ml-0"
       name="{{getClass(args.cls)}}-{{args.field}}-input"
       id="{{getClass(args.cls)}}-{{args.field}}-input"
-      [ngModel]="objectFromPath(args.path, args.index)[args.field]() == 't'"
+      [ngModel]="objectFromPath(args.path, args.index)[args.field]() === 't'"
       (ngModelChange)="fieldValueChange(args.path, args.index, args.field, $event)"
       (change)="afterFieldChange(args.path, args.index, args.field)"
       [pattern]="fieldPattern(getClass(args.cls), args.field)"
@@ -276,8 +276,8 @@
 
   <!-- Container div for name / pref name tabs -->
   <div class="border rounded p-2" [ngClass]="{
-    'border-primary': nameTab == 'primary', 
-    'border-success': nameTab == 'preferred'}">
+    'border-primary': nameTab === 'primary', 
+    'border-success': nameTab === 'preferred'}">
     <div [ngbNavOutlet]="nameNav"></div>
   </div>
 
@@ -613,7 +613,7 @@
           <div class="form-inline">
             <input class="form-check-input" type="checkbox" 
               [disabled]="waiver.isdeleted()"
-              id="waiver-holds-{{waiver.id()}}" [ngModel]="waiver.place_holds() == 't'"
+              id="waiver-holds-{{waiver.id()}}" [ngModel]="waiver.place_holds() === 't'"
               (ngModelChange)="fieldValueChange('waiver_entries', index, 'place_holds', $event)"
               (change)="afterFieldChange('waiver_entries', index, 'place_holds')"/>
             <label class="form-check-label"
@@ -622,7 +622,7 @@
           <div class="form-inline">
             <input class="form-check-input" type="checkbox" 
               [disabled]="waiver.isdeleted()"
-              id="waiver-history-{{waiver.id()}}" [ngModel]="waiver.view_history() == 't'"
+              id="waiver-history-{{waiver.id()}}" [ngModel]="waiver.view_history() === 't'"
               (ngModelChange)="fieldValueChange('waiver_entries', index, 'view_history', $event)"
               (change)="afterFieldChange('waiver_entries', index, 'view_history')"/>
             <label class="form-check-label"
@@ -633,7 +633,7 @@
           <div class="form-inline">
             <input class="form-check-input" type="checkbox" 
               [disabled]="waiver.isdeleted()"
-              id="waiver-pickup-{{waiver.id()}}" [ngModel]="waiver.pickup_holds() == 't'"
+              id="waiver-pickup-{{waiver.id()}}" [ngModel]="waiver.pickup_holds() === 't'"
               (ngModelChange)="fieldValueChange('waiver_entries', index, 'pickup_hold', $event)"
               (change)="afterFieldChange('waiver_entries', index, 'pickup_hold')"/>
             <label class="form-check-label"
@@ -642,7 +642,7 @@
           <div class="form-inline">
             <input class="form-check-input" type="checkbox" 
               [disabled]="waiver.isdeleted()"
-              id="waiver-checkout-{{waiver.id()}}" [ngModel]="waiver.checkout_items() == 't'"
+              id="waiver-checkout-{{waiver.id()}}" [ngModel]="waiver.checkout_items() === 't'"
               (ngModelChange)="fieldValueChange('waiver_entries', index, 'checkout_items', $event)"
               (change)="afterFieldChange('waiver_entries', index, 'checkout_items')"/>
             <label class="form-check-label"

diff --git a/Open-ILS/src/eg2/src/app/staff/share/circ/events-dialog.component.html b/Open-ILS/src/eg2/src/app/staff/share/circ/events-dialog.component.html
index 69569b3..357985d 100644 (file)
--- a/Open-ILS/src/eg2/src/app/staff/share/circ/events-dialog.component.html
+++ b/Open-ILS/src/eg2/src/app/staff/share/circ/events-dialog.component.html
@@ -21,7 +21,7 @@
         <div class="card-body">
           <div class="font-weight-bold">{{copyBarcode}}</div>
           <div>{{evt.desc}}</div>
-          <ng-container *ngIf="evt.textcode == 'COPY_ALERT_MESSAGE'">
+          <ng-container *ngIf="evt.textcode === 'COPY_ALERT_MESSAGE'">
             <ng-container *ngIf="!isArray(evt.payload)">
               <!-- Traditional copy.alert_message value in payload -->
               <div class="mt-2 font-weight-bold">{{evt.payload}}</div>
@@ -34,7 +34,7 @@
               </div>
             </ng-container>
           </ng-container>
-          <ng-container *ngIf="evt.textcode == 'ITEM_ON_HOLDS_SHELF'">
+          <ng-container *ngIf="evt.textcode === 'ITEM_ON_HOLDS_SHELF'">
             <a target="_blank" class="mt-3"
               routerLink="/staff/circ/patron/{{patronId}}/checkout">{{patronName}}</a>.
 

diff --git a/Open-ILS/src/eg2/src/app/staff/share/circ/grid.component.html b/Open-ILS/src/eg2/src/app/staff/share/circ/grid.component.html
index 31c008c..12d1ce4 100644 (file)
--- a/Open-ILS/src/eg2/src/app/staff/share/circ/grid.component.html
+++ b/Open-ILS/src/eg2/src/app/staff/share/circ/grid.component.html
@@ -38,7 +38,7 @@
   [rowClassCallback]="rowClass" [persistKey]="persistKey"
   [useLocalSort]="true" [cellTextGenerator]="cellTextGenerator">
 
-  <ng-container *ngIf="menuStyle == 'full'">
+  <ng-container *ngIf="menuStyle === 'full'">
 
     <eg-grid-toolbar-action
       i18n-label label="Print Item Receipt(s)" (onClick)="printReceipts($event)">

diff --git a/Open-ILS/src/eg2/src/app/staff/share/circ/route-dialog.component.html b/Open-ILS/src/eg2/src/app/staff/share/circ/route-dialog.component.html
index 0d065de..77d238c 100644 (file)
--- a/Open-ILS/src/eg2/src/app/staff/share/circ/route-dialog.component.html
+++ b/Open-ILS/src/eg2/src/app/staff/share/circ/route-dialog.component.html
@@ -61,17 +61,17 @@
     <ul>
       <li *ngFor="let note of checkin.hold.notes()">
         <strong>{{note.title()}}</strong>: {{note.body()}}
-        <span *ngIf="note.slip() =='t' || note.pub() == 't'" i18n>[Patron-visible]</span>
+        <span *ngIf="note.slip() ==='t' || note.pub() === 't'" i18n>[Patron-visible]</span>
       </li>
     </ul>
   </div>
 </ng-template>
 
 <ng-template #holdShelfTmpl>
-  <div *ngIf="checkin.hold.behind_desk() == 't'" i18n>
+  <div *ngIf="checkin.hold.behind_desk() === 't'" i18n>
     This item should be routed to the <strong>Private Holds Shelf</strong>
   </div>
-  <div *ngIf="checkin.hold.behind_desk() == 'f'" i18n>
+  <div *ngIf="checkin.hold.behind_desk() === 'f'" i18n>
     This item should be routed to the <strong>Public Holds Shelf</strong>
   </div>
   <br/>
@@ -82,7 +82,7 @@
   <!-- in hold shelf mode, we need to specify the notification prefs -->
   <div *ngIf="checkin.hold.phone_notify()" i18n>Notify by phone: {{checkin.hold.phone_notify()}}</div>
   <div *ngIf="checkin.hold.sms_notify()" i18n>Notify by text: {{checkin.hold.sms_notify()}}</div>
-  <div *ngIf="checkin.hold.email_notify() == 't'" i18n>Notify by email: {{checkin.patron.email()}}</div>
+  <div *ngIf="checkin.hold.email_notify() === 't'" i18n>Notify by email: {{checkin.patron.email()}}</div>
 
   <ng-container *ngTemplateOutlet="holdSummary"></ng-container>
   <br/>
@@ -130,11 +130,11 @@
 <ng-template #dialogContent>
   <div class="modal-header">
     <h4>
-      <ng-container *ngIf="slip == 'hold_shelf_slip'">
+      <ng-container *ngIf="slip === 'hold_shelf_slip'">
         <strong i18n>Hold Slip</strong><br/>
         <img class="p-2" src="/images/portal/holds.png" i18n-alt alt="holds icon"/>
       </ng-container>
-      <ng-container *ngIf="slip != 'hold_shelf_slip'">
+      <ng-container *ngIf="slip !== 'hold_shelf_slip'">
         <strong i18n>Transit Slip</strong><br/>
         <img class="p-2" src="/images/transit.png" i18n-alt alt="transit van icon"/>
       </ng-container>
@@ -145,10 +145,10 @@
     </button>
   </div>
   <div class="modal-body">
-    <ng-container *ngIf="slip == 'hold_shelf_slip'">
+    <ng-container *ngIf="slip === 'hold_shelf_slip'">
       <ng-container *ngTemplateOutlet="holdShelfTmpl"></ng-container>
     </ng-container>
-    <ng-container *ngIf="slip != 'hold_shelf_slip'">
+    <ng-container *ngIf="slip !== 'hold_shelf_slip'">
       <ng-container *ngTemplateOutlet="transitTmpl"></ng-container>
     </ng-container>
   </div>

diff --git a/Open-ILS/src/eg2/src/app/staff/share/holdings/copy-alert-manager.component.html b/Open-ILS/src/eg2/src/app/staff/share/holdings/copy-alert-manager.component.html
index 99b51ee..f94bda5 100644 (file)
--- a/Open-ILS/src/eg2/src/app/staff/share/holdings/copy-alert-manager.component.html
+++ b/Open-ILS/src/eg2/src/app/staff/share/holdings/copy-alert-manager.component.html
@@ -74,7 +74,7 @@
     </div>
 
     <div class="row border-top mt-3 pt-3"
-      *ngIf="mode == 'checkin' && nextStatuses.length > 0; let index = index">
+      *ngIf="mode === 'checkin' && nextStatuses.length > 0; let index = index">
       <div class="col-lg-4" i18n>Next item status:</div>
       <div class="col-lg-5">
         <ng-container *ngIf="nextStatuses.length == 1">

diff --git a/Open-ILS/src/eg2/src/app/staff/share/patron/summary.component.html b/Open-ILS/src/eg2/src/app/staff/share/patron/summary.component.html
index 11f1646..5971bac 100644 (file)
--- a/Open-ILS/src/eg2/src/app/staff/share/patron/summary.component.html
+++ b/Open-ILS/src/eg2/src/app/staff/share/patron/summary.component.html
@@ -18,7 +18,7 @@
     </div>
   </div>
 
-  <div class="row mb-1 alert alert-warning p-0" *ngIf="p().juvenile() == 't'">
+  <div class="row mb-1 alert alert-warning p-0" *ngIf="p().juvenile() === 't'">
     <div class="col-lg-12" i18n>
       Juvenile Account
     </div>
@@ -185,10 +185,10 @@
       <div class="col-lg-5" i18n>{{waiver.name()}}</div>
       <div class="col-lg-7">
         <ul>
-          <li *ngIf="waiver.place_holds() == 't'" i18n>Place holds</li>
-          <li *ngIf="waiver.pickup_holds() == 't'" i18n>Pick up holds</li>
-          <li *ngIf="waiver.view_history() == 't'" i18n>View borrowing history</li>
-          <li *ngIf="waiver.checkout_items() == 't'" i18n>Check out items</li>
+          <li *ngIf="waiver.place_holds() === 't'" i18n>Place holds</li>
+          <li *ngIf="waiver.pickup_holds() === 't'" i18n>Pick up holds</li>
+          <li *ngIf="waiver.view_history() === 't'" i18n>View borrowing history</li>
+          <li *ngIf="waiver.checkout_items() === 't'" i18n>Check out items</li>
         </ul>
       </div>
     </div>
@@ -199,7 +199,7 @@
   <div class="row mb-1" *ngFor="let addr of p().addresses()">
     <div class="col-lg-12">
       <fieldset>
-        <legend class="d-flex" [ngClass]="{'alert alert-danger p-0': addr.valid() == 'f'}">
+        <legend class="d-flex" [ngClass]="{'alert alert-danger p-0': addr.valid() === 'f'}">
           <div class="flex-1">{{addr.address_type()}}</div>
           <div>
             <a class="mr-2" href="javascript:;"