Address hash/list thinko; Ensure initialization

Two cascading defects were identified after being reported by users. The
first, which was only a potential issue, was an apparent lack of mod_perl
initialization for the item-age record feed.  While not the direct cause
of the error message, a lack of initialization here would manifest in the
same way.  So, we check that initialization.

Feed-generating callbacks were not being constructed properly due to a
simple thinko in the construction of the default record format list provided
by the SuperCat backend.  We need a list of two hashes, not a hash of two
keys.

Signed-off-by: Mike Rylander <mrylander@gmail.com>
Signed-off-by: Jason Stephenson <jstephenson@mvlc.org>

diff --git a/Open-ILS/src/perlmods/lib/OpenILS/Application/SuperCat.pm b/Open-ILS/src/perlmods/lib/OpenILS/Application/SuperCat.pm
index c8d35b6..2e7000e 100644 (file)
--- a/Open-ILS/src/perlmods/lib/OpenILS/Application/SuperCat.pm
+++ b/Open-ILS/src/perlmods/lib/OpenILS/Application/SuperCat.pm
@@ -3002,8 +3002,8 @@ sub list_record_formats {
                          docs            => 'http://www.loc.gov/marcxml/',
                          schema_location => 'http://www.loc.gov/standards/marcxml/schema/MARC21slim.xsd',
                        },
-                 marc21 => { docs => 'http://www.loc.gov/marc/' }
                },
+               { marc21 => { docs => 'http://www.loc.gov/marc/' } }
        );
 
        for my $type ( keys %record_xslt ) {

diff --git a/Open-ILS/src/perlmods/lib/OpenILS/WWW/SuperCat.pm b/Open-ILS/src/perlmods/lib/OpenILS/WWW/SuperCat.pm
index 1956b5a..16fdb24 100644 (file)
--- a/Open-ILS/src/perlmods/lib/OpenILS/WWW/SuperCat.pm
+++ b/Open-ILS/src/perlmods/lib/OpenILS/WWW/SuperCat.pm
@@ -1713,6 +1713,8 @@ sub item_age_browse {
     my $apache = shift;
     return Apache2::Const::DECLINED if (-e $apache->filename);
 
+    check_child_init();
+
     my $cgi = new CGI;
     my $year = (gmtime())[5] + 1900;