forward-porting 12847 (hold expire date warning bug), which was missed before
authorerickson <erickson@dcc99617-32d9-48b4-a31d-7c20da2025e4>
Mon, 27 Apr 2009 19:52:06 +0000 (19:52 +0000)
committererickson <erickson@dcc99617-32d9-48b4-a31d-7c20da2025e4>
Mon, 27 Apr 2009 19:52:06 +0000 (19:52 +0000)
git-svn-id: svn://svn.open-ils.org/ILS/trunk@13000 dcc99617-32d9-48b4-a31d-7c20da2025e4

Open-ILS/web/opac/skin/default/js/myopac.js

index f50b060..2229613 100644 (file)
@@ -358,8 +358,9 @@ function myOPACDrawHolds(r) {
 
         $n(row, 'myopac_holds_selected_chkbx').checked = false;
 
+        var exp_date;
         if(h.expire_time()) {
-            var exp_date = dojo.date.stamp.fromISOString(h.expire_time());
+            exp_date = dojo.date.stamp.fromISOString(h.expire_time());
             $n(row, 'myopac_hold_expire_time').appendChild(
                 text(dojo.date.locale.format(exp_date, {selector:'date'})));
         }
@@ -367,7 +368,7 @@ function myOPACDrawHolds(r) {
                unHideMe(row);
 
         var interval = fetchOrgSettingDefault(G.user.home_ou(), 'circ.hold_expire_alert_interval');
-        if(interval) {
+        if(interval && exp_date) {
             secs = interval_to_seconds(interval) * 1000;
             var diff = exp_date.getTime() - new Date().getTime();
             if(diff < secs)