clarify open-ils.acq.picklist.clone

Method is now clear that _nothing_ of the acq.picklist row
itself gets copied over.

Signed-off-by: Galen Charlton <gmc@equinoxinitiative.org>

diff --git a/Open-ILS/src/perlmods/lib/OpenILS/Application/Acq/Order.pm b/Open-ILS/src/perlmods/lib/OpenILS/Application/Acq/Order.pm
index 331baf2..14c797b 100644 (file)
--- a/Open-ILS/src/perlmods/lib/OpenILS/Application/Acq/Order.pm
+++ b/Open-ILS/src/perlmods/lib/OpenILS/Application/Acq/Order.pm
@@ -1100,7 +1100,6 @@ sub create_picklist {
     $picklist->create_time('now');
     $picklist->edit_time('now');
     $picklist->org_unit($mgr->editor->requestor->ws_ou);
-    $picklist->owner($mgr->editor->requestor->id);
     $picklist->$_($args{$_}) for keys %args;
     $picklist->clear_id;
     $mgr->picklist($picklist);
@@ -2562,7 +2561,9 @@ __PACKAGE__->register_method(
     method    => 'clone_picklist_api',
     api_name  => 'open-ils.acq.picklist.clone',
     signature => {
-        desc   => 'Clones a picklist, including lineitem and lineitem details',
+        desc   => 'Clones a picklist, including lineitem and lineitem details.
+                   Owner, creator, editor, and org unit are set to match
+                   the logged in user.',
         params => [
             {desc => 'Authentication token', type => 'string'},
             {desc => 'Picklist ID', type => 'number'},
@@ -2579,8 +2580,14 @@ sub clone_picklist_api {
     return $e->die_event unless $e->checkauth;
     my $mgr = OpenILS::Application::Acq::BatchManager->new(editor => $e, conn => $conn);
 
-    my $old_pl = $e->retrieve_acq_picklist($pl_id);
-    my $new_pl = create_picklist($mgr, %{$old_pl->to_bare_hash}, name => $name) or return $e->die_event;
+    my $old_pl;
+    $old_pl = $e->retrieve_acq_picklist($pl_id) or return $e->die_event;
+    # we're not retaining _any_ part of the acq.picklist row itself for the moment,
+    # as the new name comes from user input and everything else either comes from the
+    # logged-in user's session (owner, creator, editor, org_unit) or the current
+    # time (create_time, edit_time)
+
+    my $new_pl = create_picklist($mgr, name => $name) or return $e->die_event;
 
     my $li_ids = $e->search_acq_lineitem({picklist => $pl_id}, {idlist => 1});