Make existing Google Book Search link functions and IDs less generic; part of #50

git-svn-id: svn://svn.open-ils.org/ILS/trunk@12466 dcc99617-32d9-48b4-a31d-7c20da2025e4

diff --git a/Open-ILS/web/opac/skin/default/js/result_common.js b/Open-ILS/web/opac/skin/default/js/result_common.js
index 636f18c..300b571 100644 (file)
--- a/Open-ILS/web/opac/skin/default/js/result_common.js
+++ b/Open-ILS/web/opac/skin/default/js/result_common.js
@@ -3,7 +3,7 @@ var recordsHandled = 0;
 var recordsCache = [];
 var lowHitCount = 4;
 var isbnList = '';
-var googleBooks = true;
+var googleBooksLink = true;
 
 var resultFetchAllRecords = false;
 var resultCompiledSearch = null;
@@ -15,7 +15,7 @@ if( findCurrentPage() == MRESULT || findCurrentPage() == RRESULT ) {
        G.evt.result.copyCountsReceived.push(resultDisplayCopyCounts);
        G.evt.result.allRecordsReceived.push(resultBuildCaches, resultDrawSubjects, 
       resultDrawAuthors, resultDrawSeries, function(){unHideMe($('result_info_2'))},
-         fetchGoogleBooks);
+         fetchGoogleBooksLink);
 
        attachEvt('result','lowHits',resultLowHits);
        attachEvt('result','zeroHits',resultZeroHits);
@@ -414,11 +414,11 @@ function buildunAPISpan (span, type, id) {
        );
 }
 
-function unhideGoogleBooks (data) {
+function unhideGoogleBooksLink (data) {
     for ( var i in data ) {
         //if (data[i].preview == 'noview') continue;
 
-        var gbspan = $n(document.documentElement, 'googleBooks-' + i);
+        var gbspan = $n(document.documentElement, 'googleBooksLink-' + i);
         var gba = $n(gbspan, "googleBooks-link");
 
         gba.setAttribute(
@@ -440,8 +440,8 @@ function resultDisplayRecord(rec, pos, is_mr) {
        var r = table.rows[pos + 1];
     var currentISBN = cleanISBN(rec.isbn());
 
-    if (googleBooks) {
-           var gbspan = $n(r, "googleBooks");
+    if (googleBooksLink) {
+           var gbspan = $n(r, "googleBooksLink");
         if (currentISBN) {
             gbspan.setAttribute(
                 'name',
@@ -598,13 +598,13 @@ function resultBuildFormatIcons( row, rec, is_mr ) {
        }
 }
 
-function fetchGoogleBooks () {
-    if (isbnList && googleBooks) {
+function fetchGoogleBooksLink () {
+    if (isbnList && googleBooksLink) {
         var scriptElement = document.createElement("script");
         scriptElement.setAttribute("id", "jsonScript");
         scriptElement.setAttribute("src",
             "http://books.google.com/books?bibkeys=" + 
-            escape(isbnList) + "&jscmd=viewapi&callback=unhideGoogleBooks");
+            escape(isbnList) + "&jscmd=viewapi&callback=unhideGoogleBooksLink");
         scriptElement.setAttribute("type", "text/javascript");
         // make the request to Google Book Search
         document.documentElement.firstChild.appendChild(scriptElement);

diff --git a/Open-ILS/web/opac/skin/default/xml/result/result_table.xml b/Open-ILS/web/opac/skin/default/xml/result/result_table.xml
index 53d24a6..5acea4c 100644 (file)
--- a/Open-ILS/web/opac/skin/default/xml/result/result_table.xml
+++ b/Open-ILS/web/opac/skin/default/xml/result/result_table.xml
@@ -130,7 +130,7 @@
                                                                        </abbr>
 
                                                                        <!-- Empty span used for creating Google Book Search-->
-                                                                       <span name="googleBooks" class="hide_me">
+                                                                       <span name="googleBooksLink" class="hide_me">
                                                                                <a style='padding-left: 8px;' class='classic_link' name="googleBooks-link">&result.googleBooks.browse;</a>
                                                                        </span>