Fix TPAC account preferences

Clean up a few problems in the TPAC "My Account" preferences area:

1. Add a missing </form> closing element, which was preventing any
   submitted changes from actually being posted to the correct URL
   (thus preventing most account preference changes such as
   notifications).
2. Remove trailing semicolon from several generated <option> elements
   for cleaner HTML.
3. Make the aria-label for the element translatable.

As we're touching a majority of the lines in the section and the lines
do not follow normal whitespace standards (mixed tabs, inconsistent
indentation, etc), clean up the whitespace.

Also turn one HTML comment into a Template::Toolkit comment.

Signed-off-by: Dan Scott <dscott@laurentian.ca>
Signed-off-by: Dan Wells <dbw2@calvin.edu>

diff --git a/Open-ILS/src/templates/opac/parts/myopac/prefs_base.tt2 b/Open-ILS/src/templates/opac/parts/myopac/prefs_base.tt2
index ec9e657..34c156d 100644 (file)
--- a/Open-ILS/src/templates/opac/parts/myopac/prefs_base.tt2
+++ b/Open-ILS/src/templates/opac/parts/myopac/prefs_base.tt2
@@ -35,19 +35,21 @@
             <a class="hide_me" href="#">[% l('Export List') %]</a><!-- what does this do? -->
         </span>
     </div>
-        <!- Select box navigation for mobile view ->
-        <div id="acct_prefs_select">
-            <form name="acct_prefs_nav">
-              <select name="acct_prefs_url" aria-label="Select a preference page" onchange="window.location.href=document.acct_prefs_nav.acct_prefs_url.options[document.acct_prefs_nav.acct_prefs_url.selectedIndex].value">
-      [% FOREACH page IN acct_prefs_pages;
-          IF page.url != prefs_page; %]
-            <option value="[% mkurl(ctx.opac_root _ '/myopac/' _ page.url, {}, ['bbid', 'offset', 'limit']) %]">[% page.name; %]</option>;
-          [% ELSE; %]
-           <option value="" disabled selected>[% page.name; %]</option>;
-          [% END;
-       END; %]
-       </select>
-      </div>
+
+    [%- # Select box navigation for mobile view %]
+    <div id="acct_prefs_select">
+        <form name="acct_prefs_nav">
+            <select name="acct_prefs_url" aria-label="[% l('Select a preference page') %]" onchange="window.location.href=document.acct_prefs_nav.acct_prefs_url.options[document.acct_prefs_nav.acct_prefs_url.selectedIndex].value">
+        [% FOREACH page IN acct_prefs_pages;
+            IF page.url != prefs_page; -%]
+            <option value="[% mkurl(ctx.opac_root _ '/myopac/' _ page.url, {}, ['bbid', 'offset', 'limit']) %]">[% page.name; %]</option>
+            [% ELSE; -%]
+            <option value="" disabled selected>[% page.name; %]</option>
+            [% END; -%]
+        [% END; -%]
+            </select>
+        </form>
+    </div>
 
     <div class="clear-both normal-height"></div>