annotating a couple sources of NPEs and fixed one. Login handling needs to be rewrit...

diff --git a/Open-ILS/src/Android/src/org/evergreen/android/accountAccess/AccountAccess.java b/Open-ILS/src/Android/src/org/evergreen/android/accountAccess/AccountAccess.java
index e653a07..7a05395 100644 (file)
--- a/Open-ILS/src/Android/src/org/evergreen/android/accountAccess/AccountAccess.java
+++ b/Open-ILS/src/Android/src/org/evergreen/android/accountAccess/AccountAccess.java
@@ -741,6 +741,10 @@ public class AccountAccess {
 
         Object resp = Utils.doRequest(conn, SERVICE_CIRC, METHOD_FETCH_HOLDS,
                 authToken, cm, new Object[] { authToken, userID });
+        if (resp == null) {
+            System.out.println("Result: null");
+            return holds;
+        }
 
         listHoldsAhr = (List<OSRFObject>) resp;
 

diff --git a/Open-ILS/src/Android/src/org/evergreen/android/accountAccess/holds/HoldsListView.java b/Open-ILS/src/Android/src/org/evergreen/android/accountAccess/holds/HoldsListView.java
index ce75475..0dbffcc 100644 (file)
--- a/Open-ILS/src/Android/src/org/evergreen/android/accountAccess/holds/HoldsListView.java
+++ b/Open-ILS/src/Android/src/org/evergreen/android/accountAccess/holds/HoldsListView.java
@@ -164,6 +164,7 @@ public class HoldsListView extends Activity {
             }
         };
 
+        // 1 NPE
         if (accountAccess.isAuthenticated()) {
             progressDialog = new ProgressDialog(context);
             progressDialog.setMessage("Loading holds");