Undo holding lib to SRE linkage (alt dist editor)

Since the legacy record dropdown piggy-backs on the OPAC display, it
doesn't work in the alt interface (which has no clear OPAC context).

Worse, this leads to a Javascript error on the first editor load for
the distribution list, preventing subsequent editors.

A better fix will require more consideration, but for now, let's
revert to the unformatted display used in 2.3.

Also, this commit removes an unnecessary conditional (it was always
true).

Signed-off-by: Dan Wells <dbw2@calvin.edu>
Signed-off-by: Mike Rylander <mrylander@gmail.com>

diff --git a/Open-ILS/src/templates/serial/subscription.tt2 b/Open-ILS/src/templates/serial/subscription.tt2
index 5d91795..5081f32 100644 (file)
--- a/Open-ILS/src/templates/serial/subscription.tt2
+++ b/Open-ILS/src/templates/serial/subscription.tt2
@@ -90,12 +90,10 @@
                     <th field="end_date" formatter="format_date">
                         [% l('End Date') %]
                     </th>
-                    [%- IF CGI.param('context') != 'scv' -%]
                     <th field="record_entry" width="20em"
                         formatter="format_bib">
                         [% l('Bibliographic Record') %]
                     </th>
-                    [%- END -%]
                     <th field="expected_date_offset">[% l('Expected Date Offset') %]</th>
                     <th field="num_dist">[% l('Number of Distributions') %]</th>
                 </tr>
@@ -123,8 +121,11 @@
                         "disabled": true, "value": sub_id
                     });
 
+                [%- IF CGI.param('context') == 'scv' -%]
                 // attach the holding_lib selector to the record_entry selector
                 dist_grid.overrideWidgetArgs.holding_lib = {'dijitArgs' : {'onChange' : function(value) { populate_sre_selector(dist_grid, value); } }};
+
+                [%- END -%]
                 var _display_grouping_store = new dojo.data.ItemFileReadStore({
                     "data": {
                         "identifier": "display_grouping",