making assumptions here about valid patron and valid patron password fields when...

Signed-off-by: Jason Etheridge <jason@EquinoxOLI.org>

diff --git a/t/04patron_status.t b/t/04patron_status.t
index 365df24..ca4ef8f 100755 (executable)
--- a/t/04patron_status.t
+++ b/t/04patron_status.t
@@ -100,14 +100,14 @@ $test->{fields} = [
                   pat      => qr/^$user_barcode$/,
                   required => 1, },
                 { field    => FID_PERSONAL_NAME,
-           pat      => qr/^$user_fullname$/o,
+           pat      => qr/^$/o, # FIXME: expose patron info with invalid password or not?
                   required => 1, },
                 { field    => FID_VALID_PATRON,
-                  pat      => qr/^Y$/,
-                  required => 1, },
+                  pat      => qr/^N$/, # FIXME: still exposing patron info if we provide Y here with an invalid password
+                  required => 0, }, # optional per spec
                 { field    => FID_VALID_PATRON_PWD,
                   pat      => qr/^N$/,
-                  required => 1, },
+                  required => 0, }, # optional per spec
                 ];
 push @tests, $test;