GridColumnPicker avoid sorting when no settings have persisted

Avoid sorting cells whose _sort value is null/undefined, which can
happen when no column settings have been persisted for the grid.

Signed-off-by: Bill Erickson <berick@esilibrary.com>

diff --git a/Open-ILS/web/js/dojo/openils/widget/GridColumnPicker.js b/Open-ILS/web/js/dojo/openils/widget/GridColumnPicker.js
index fe22694..1577162 100644 (file)
--- a/Open-ILS/web/js/dojo/openils/widget/GridColumnPicker.js
+++ b/Open-ILS/web/js/dojo/openils/widget/GridColumnPicker.js
@@ -257,7 +257,7 @@ if(!dojo._hasResource["openils.widget.GridColumnPicker"]) {
         // extract cells that have sorting applied, order lowest to highest
         buildSortList : function() {
             var sortList = this.cells.filter(
-                function(cella) { return cella._sort != 0 }
+                function(cella) { return Number(cella._sort) }
             ).sort( 
                 function(a, b) { 
                     if (Math.abs(a._sort) < Math.abs(b._sort)) return -1;