LP#2006749: Fix call to ou_ancestor_setting_perm_check in AppUtils.pm

The $self and $e arguments are missing when the ou_ancestor_setting
subroutine calls ou_ancestor_setting_perm_check in AppUtils.

The $coust argument also need to be $coust->view_perm->code for the
allowed check in ou_ancestor_setting_perm_check.

This commit corrects the call to ou_ancestor_setting_perm_check.

Signed-off-by: Jason Stephenson <jason@sigio.com>
Signed-off-by: Chris Sharp <csharp@georgialibraries.org>
Signed-off-by: Galen Charlton <gmc@equinoxOLI.org>

diff --git a/Open-ILS/src/perlmods/lib/OpenILS/Application/AppUtils.pm b/Open-ILS/src/perlmods/lib/OpenILS/Application/AppUtils.pm
index 3c32377..441d0c0 100644 (file)
--- a/Open-ILS/src/perlmods/lib/OpenILS/Application/AppUtils.pm
+++ b/Open-ILS/src/perlmods/lib/OpenILS/Application/AppUtils.pm
@@ -1318,7 +1318,7 @@ sub ou_ancestor_setting {
         my $coust = $e->retrieve_config_org_unit_setting_type([
             $name, {flesh => 1, flesh_fields => {coust => ['view_perm']}}
         ]);
-        return undef unless ou_ancestor_setting_perm_check($orgid, $coust, $auth)
+        return undef unless $self->ou_ancestor_setting_perm_check($orgid, $coust->view_perm->code, $e, $auth)
     }
 
     my $query = {from => ['actor.org_unit_ancestor_setting', $name, $orgid]};