Fine generator recycles cstore drones

Signed-off-by: Bill Erickson <berickxx@gmail.com>

diff --git a/Open-ILS/src/perlmods/lib/OpenILS/Application/Circ/CircCommon.pm b/Open-ILS/src/perlmods/lib/OpenILS/Application/Circ/CircCommon.pm
index 3d23154..ed58009 100644 (file)
--- a/Open-ILS/src/perlmods/lib/OpenILS/Application/Circ/CircCommon.pm
+++ b/Open-ILS/src/perlmods/lib/OpenILS/Application/Circ/CircCommon.pm
@@ -505,9 +505,13 @@ sub generate_fines {
 
         eval {
 
-            # Clean up after previous transaction.  
-            # This is a no-op if there is no open transaction.
-            $e->xact_rollback if $commit;
+            # Clean up after previous transaction and disconnect from
+            # cstore drone.  Forcing a disconnect helps prevent memory
+            # exhaustion when processing huge batches of transactions.
+            # Note the disconnect is forced here instead of during
+            # $e->xact_commit to ensure a disconnect happens with every
+            # transaction regardless of whether a billing was created.
+            $e->rollback if $commit;
 
             $logger->info(sprintf("Processing $ctype %d...", $c->id));