Add VIEW_CASH_REPORTS perm

Because some groups would like to limit that interface more significantly.

Signed-off-by: Thomas Berezansky <tsbere@mvlc.org>

diff --git a/Open-ILS/src/perlmods/lib/OpenILS/Application/Circ/Money.pm b/Open-ILS/src/perlmods/lib/OpenILS/Application/Circ/Money.pm
index b8cc573..de962e2 100644 (file)
--- a/Open-ILS/src/perlmods/lib/OpenILS/Application/Circ/Money.pm
+++ b/Open-ILS/src/perlmods/lib/OpenILS/Application/Circ/Money.pm
@@ -899,7 +899,7 @@ sub desk_payments {
     my( $self, $conn, $auth, $org, $start_date, $end_date ) = @_;
     my $e = new_editor(authtoken=>$auth);
     return $e->event unless $e->checkauth;
-    return $e->event unless $e->allowed('VIEW_TRANSACTION', $org);
+    return $e->event unless $e->allowed('VIEW_CASH_REPORTS', $org);
     my $data = $U->storagereq(
         'open-ils.storage.money.org_unit.desk_payments.atomic',
         $org, $start_date, $end_date );
@@ -918,7 +918,7 @@ sub user_payments {
     my( $self, $conn, $auth, $org, $start_date, $end_date ) = @_;
     my $e = new_editor(authtoken=>$auth);
     return $e->event unless $e->checkauth;
-    return $e->event unless $e->allowed('VIEW_TRANSACTION', $org);
+    return $e->event unless $e->allowed('VIEW_CASH_REPORTS', $org);
     my $data = $U->storagereq(
         'open-ils.storage.money.org_unit.user_payments.atomic',
         $org, $start_date, $end_date );

diff --git a/Open-ILS/src/sql/Pg/950.data.seed-values.sql b/Open-ILS/src/sql/Pg/950.data.seed-values.sql
index d53ae14..b4c3c54 100644 (file)
--- a/Open-ILS/src/sql/Pg/950.data.seed-values.sql
+++ b/Open-ILS/src/sql/Pg/950.data.seed-values.sql
@@ -1543,7 +1543,9 @@ INSERT INTO permission.perm_list ( id, code, description ) VALUES
  ( 526, 'UPDATE_PATRON_STAT_CAT_ENTRY_DEFAULT', oils_i18n_gettext( 526, 
     'User may reset a default entry in a patron statistical category', 'ppl', 'description' )),
  ( 527, 'DELETE_PATRON_STAT_CAT_ENTRY_DEFAULT', oils_i18n_gettext( 527, 
-    'User may unset a default entry in a patron statistical category', 'ppl', 'description' ));
+    'User may unset a default entry in a patron statistical category', 'ppl', 'description' )),
+ ( 528, 'VIEW_CASH_REPORTS', oils_i18n_gettext( 528,
+    'User may view data via the cash reports interface', 'ppl', 'description' ));
 
 SELECT SETVAL('permission.perm_list_id_seq'::TEXT, 1000);
 
@@ -1644,7 +1646,8 @@ INSERT INTO permission.grp_perm_map (grp, perm, depth, grantable)
                        'VIEW_USER_FINES_SUMMARY',
                        'VIEW_USER_TRANSACTIONS',
                        'VIEW_VOLUME_NOTES',
-                       'VIEW_ZIP_DATA');
+                       'VIEW_ZIP_DATA',
+            'VIEW_CASH_REPORTS');
 
 INSERT INTO permission.grp_perm_map (grp, perm, depth, grantable)
        SELECT
@@ -2110,7 +2113,8 @@ INSERT INTO permission.grp_perm_map (grp, perm, depth, grantable)
                        'VIEW_STANDING_PENALTY',
                        'VOID_BILLING',
             'TRANSIT_CHECKIN_INTERVAL_BLOCK.override',
-                       'VOLUME_HOLDS');
+                       'VOLUME_HOLDS',
+            'VIEW_CASH_REPORTS');
 
 
 -- Add basic sys admin permissions to the Local Administrator group

diff --git a/Open-ILS/src/sql/Pg/upgrade/XXXX.cash_reports_perm.sql b/Open-ILS/src/sql/Pg/upgrade/XXXX.cash_reports_perm.sql
new file mode 100644 (file)
index 0000000..dbf34a9
--- /dev/null
+++ b/Open-ILS/src/sql/Pg/upgrade/XXXX.cash_reports_perm.sql
@@ -0,0 +1,3 @@
+INSERT INTO permission.perm_list (code, description) VALUES
+('VIEW_CASH_REPORTS', 'User may view data via the cash reports interface');
+

diff --git a/Open-ILS/xul/staff_client/server/admin/cash_reports.js b/Open-ILS/xul/staff_client/server/admin/cash_reports.js
index c55431d..89a2302 100644 (file)
--- a/Open-ILS/xul/staff_client/server/admin/cash_reports.js
+++ b/Open-ILS/xul/staff_client/server/admin/cash_reports.js
@@ -1,7 +1,7 @@
 var FETCH_DESK_PAYMENTS = 'open-ils.circ:open-ils.circ.money.org_unit.desk_payments';
 var FETCH_USER_PAYMENTS = 'open-ils.circ:open-ils.circ.money.org_unit.user_payments';
 
-var myPerms = [ 'VIEW_TRANSACTION' ];
+var myPerms = [ 'VIEW_CASH_REPORTS' ];
 var crBaseOrg;
 
 function crInit() {
@@ -55,7 +55,7 @@ function crCurrentOrg() {
 
 function crBuildOrgs() {
 
-    var org = findOrgUnit(PERMS['VIEW_TRANSACTION']);
+    var org = findOrgUnit(PERMS['VIEW_CASH_REPORTS']);
 
     if(!org) {
         $('cr_orgs').disabled = true;