LP1906842 PLACE_UNFILLABLE_HOLD permission not working if no titles exist. collab/Callender/unfillable_hold_no_item_fix
authorSteven Callender <stevecallender@esilibrary.com>
Fri, 4 Dec 2020 14:59:25 +0000 (09:59 -0500)
committerSteven Callender <stevecallender@esilibrary.com>
Fri, 4 Dec 2020 14:59:25 +0000 (09:59 -0500)
This fix will correct an issue where the screen just keeps looping to the override screen when
trying to place a hold that has no titles available for it.

Signed-off-by: Steven Callender <stevecallender@esilibrary.com>
Open-ILS/src/perlmods/lib/OpenILS/Application/Circ/Holds.pm

index 25f2633..66625dd 100644 (file)
@@ -104,7 +104,7 @@ sub test_and_create_hold_batch {
         my $res;
         ($res) = $self->method_lookup(
             'open-ils.circ.title_hold.is_possible')->run($auth, $params, $override ? $oargs : {});
-        if ($res->{'success'} == 1) {
+        if ($res->{'success'} == 1 || ($override && $res->{place_unfillable})) {
 
             $params->{'depth'} = $res->{'depth'} if $res->{'depth'};