LP#1705286 - webstaff Prevent View holds grid being refreshed too often user/cesardv/LP1705286_webstaff_ViewHolds_grid_refresh
authorCesar Velez <cesar.velez@equinoxinitiative.org>
Thu, 20 Jul 2017 15:02:12 +0000 (11:02 -0400)
committerCesar Velez <cesar.velez@equinoxinitiative.org>
Thu, 20 Jul 2017 15:06:17 +0000 (11:06 -0400)
This is attempting to prevent un-necessary calls to refresh the
holds grid, and prevent duplicates.

Signed-off by: Cesar Velez <cesar.velez@equinoxinitiative.org>

Open-ILS/web/js/ui/default/staff/cat/catalog/app.js

index e71f74f..9b9b018 100644 (file)
@@ -1556,6 +1556,9 @@ function($scope , $routeParams , $location , $window , $q , egCore , egHolds , e
     // refresh the list of record holds when the pickup lib is changed.
     $scope.pickup_ou = egCore.org.get(egCore.auth.user().ws_ou());
     $scope.pickup_ou_changed = function(org) {
+        // avoid refreshing if nothing changed or just loading eg-org-selector.
+        if ($scope.pickup_ou == org) return;
+        
         $scope.pickup_ou = org;
         provider.refresh();
     }
@@ -1663,9 +1666,10 @@ function($scope , $routeParams , $location , $window , $q , egCore , egHolds , e
                 break;
 
             case 'holds':
-                $scope.detail_hold_record_id = $scope.record_id; 
-                // refresh the holds grid
-                provider.refresh();
+                if ($scope.detail_hold_record_id != $scope.record_id){
+                    $scope.detail_hold_record_id = $scope.record_id;
+                    provider.refresh();
+                }
 
                 break;
         }