LP#1089468: QueryParser is not re-entrant

Because the ->parse() method of QueryParser did not clear an instance's
parse tree prior to parsing, any time a QP instance was reused, the user
ended up with a corrupted parse tree containing bits of old queries as
well as bits of the new query.

Signed-off-by: Jared Camins-Esakov <jcamins@cpbibliography.com>

diff --git a/Open-ILS/src/perlmods/lib/OpenILS/Application/Storage/QueryParser.pm b/Open-ILS/src/perlmods/lib/OpenILS/Application/Storage/QueryParser.pm
index 7ee0402..0b39cac 100644 (file)
--- a/Open-ILS/src/perlmods/lib/OpenILS/Application/Storage/QueryParser.pm
+++ b/Open-ILS/src/perlmods/lib/OpenILS/Application/Storage/QueryParser.pm
@@ -459,6 +459,11 @@ sub parse {
     my $self = shift;
     my $pkg = ref($self) || $self;
     warn " ** parse package is $pkg\n" if $self->debug;
+
+    # Without this, calling ->parse() twice on a single instance results
+    # in parse tree corruption
+    undef $self->{_parse_tree};
+
     $self->parse_tree(
         $self->decompose(
             $self->query( shift() )