lp1895738 need eg.orgselect.hopeless.wide_holds user/mmorgan/lp1895738-hopeless-orgselect-signoff
authorJason Etheridge <jason@EquinoxInitiative.org>
Thu, 1 Oct 2020 15:45:44 +0000 (11:45 -0400)
committerMichele Morgan <mmorgan@noblenet.org>
Wed, 10 Mar 2021 18:13:53 +0000 (13:13 -0500)
This fixes the following:

ERROR Error: Uncaught (in promise): No user or workstation setting type exists for: "eg.orgselect.hopeless.wide_holds".
Create a ws/user setting type or use setLocalItem() to store the value locally.

However, it exposes a different (harmless?) error within the /eg2 holds grid:

ERROR Error: ExpressionChangedAfterItHasBeenCheckedError: Expression has changed after it was checked. Previous value for 'ng-untouched': 'true'. Current value: 'false'.

Signed-off-by: Jason Etheridge <jason@EquinoxInitiative.org>
Signed-off-by: Michele Morgan <mmorgan@noblenet.org>
Open-ILS/src/sql/Pg/950.data.seed-values.sql
Open-ILS/src/sql/Pg/upgrade/XXXX.data.patron-search-org-select.sql [new file with mode: 0644]

index 55072f4..bb6064e 100644 (file)
@@ -20877,6 +20877,13 @@ VALUES (
         'cwst', 'label'
     )
 ), (
+    'eg.orgselect.hopeless.wide_holds', 'gui', 'integer',
+    oils_i18n_gettext(
+        'eg.orgselect.hopeless.wide_holds',
+        'Default org unit for hopeless holds interface',
+        'cwst', 'label'
+    )
+), (
     'eg.grid.cat.authority.browse', 'gui', 'object',
     oils_i18n_gettext(
     'eg.grid.cat.authority.browse',
diff --git a/Open-ILS/src/sql/Pg/upgrade/XXXX.data.patron-search-org-select.sql b/Open-ILS/src/sql/Pg/upgrade/XXXX.data.patron-search-org-select.sql
new file mode 100644 (file)
index 0000000..a954fb4
--- /dev/null
@@ -0,0 +1,17 @@
+BEGIN;
+
+SELECT evergreen.upgrade_deps_block_check('XXXX', :eg_version);
+
+INSERT INTO config.workstation_setting_type (name, grp, datatype, label)
+VALUES (
+    'eg.orgselect.hopeless.wide_holds', 'gui', 'integer',
+    oils_i18n_gettext(
+        'eg.orgselect.hopeless.wide_holds',
+        'Default org unit for hopeless holds interface',
+        'cwst', 'label'
+    )
+);
+
+COMMIT;
+
+