lp1724008 nav bar wraps user/mrisher/lp1724008-navbar-2-lines
authorMike Risher <mrisher@catalyte.io>
Fri, 13 Mar 2020 23:56:56 +0000 (23:56 +0000)
committerMike Risher <mrisher@catalyte.io>
Mon, 16 Mar 2020 23:14:06 +0000 (23:14 +0000)
With some screen sizes the navbar wraps to two or more lines and
this osbscures content on the page.  Address this issue so that
content at the top of the page remains visible.

Signed-off-by: Mike Risher <mrisher@catalyte.io>
Changes to be committed:
modified:   Open-ILS/src/templates/staff/circ/patron/index.tt2
modified:   Open-ILS/src/templates/staff/circ/patron/register.tt2
modified:   Open-ILS/src/templates/staff/circ/patron/t_edit.tt2
modified:   Open-ILS/src/templates/staff/css/circ.css.tt2
modified:   Open-ILS/src/templates/staff/css/style.css.tt2

Open-ILS/src/eg2/src/app/staff/admin/local/search-filter/search-filter-group-entries.component.html
Open-ILS/src/templates/staff/circ/patron/index.tt2
Open-ILS/src/templates/staff/circ/patron/register.tt2
Open-ILS/src/templates/staff/circ/patron/t_edit.tt2
Open-ILS/src/templates/staff/css/circ.css.tt2
Open-ILS/src/templates/staff/css/style.css.tt2

index 43dc762..a2950c8 100644 (file)
@@ -20,7 +20,7 @@
     (onClick)="deleteSelected($event)"></eg-grid-toolbar-action>
 </eg-grid>
 
-<eg-query-dialog #queryDialog [record]="recordToEdit"></eg-query-dialog>
+<eg-query-dialog #queryDialog></eg-query-dialog>
 
 <eg-string #createQueryString i18n-text text="New Query Added"></eg-string>
 <eg-string #queryRequiredString i18n-text text="Error! Some fields not filled out!"></eg-string>
index a36c758..47818de 100644 (file)
@@ -81,14 +81,6 @@ angular.module('egCoreMod').run(['egStrings', function(s) {
 }]);
 </script>
 
-<!-- add room for the fixed navigation elements -->
-<style ng-if="is_patron_edit">
-  #top-content-container { padding-top: 120px; }
-</style>
-<style ng-if="!is_patron_edit">
-  #top-content-container { padding-top: 80px; }
-</style>
-
 [% END %]
 
 <div class="row" id="patron-fixed-tabs">
index 0df6f9e..8a004da 100644 (file)
@@ -19,10 +19,7 @@ angular.module('egCoreMod').run(['egStrings', function(s) {
 }]);
 </script>
 <link rel="stylesheet" href="[% ctx.base_path %]/staff/css/circ.css" />
-<style>
-  /* add room for the fixed navigation elements */
-  #top-content-container { padding-top: 170px; }
-</style>
+
 [% END %]
 
 <div ng-view></div>
index 1c66575..544a50b 100644 (file)
@@ -1,7 +1,7 @@
 [% DOC_IMG = '/images/question-mark.png' %]
 
 <!-- register banner -->
-<div ng-if="!patron_id" ng-class='{"patron-reg-fixed-bar":!offline}'>
+<div ng-if="!patron_id" ng-class='{"patron-reg-bar":!offline}'>
 
   <div class="container-fluid" style="text-align:center">
     <div class="alert alert-info alert-less-pad strong-text-2">
index 3e44581..c9b166b 100644 (file)
@@ -39,10 +39,6 @@ but the ones I'm finding aren't quite cutting it..*/
 }
 
 #patron-fixed-tabs {
-    position: fixed;
-    top: 50px;
-    right: 15px;
-    left: 45px;
     padding-top: 20px;
     padding-top: 10px;
     z-index: 4;
@@ -142,12 +138,7 @@ but the ones I'm finding aren't quite cutting it..*/
     font-weight: normal;
 }
 
-.patron-reg-fixed-bar {
-    position: fixed;
-    top:50px;
-    right: 20px;
-    left: 20px;
-    padding-top: 20px;
+.patron-reg-bar {    
     padding-bottom: 10px;
     z-index: 1;
     background-color: rgba(255,255,255,1);
index 5db43ef..bf5b525 100644 (file)
@@ -51,9 +51,13 @@ body {
      * narrower than the default Bootstrapp container gutters.
      */
     width: 95%;
-    padding-top: 70px;
+    padding-top: 2px;
 }
 
+/* this prevents nav bar from covering content when it takes up 2 lines */
+#top-navbar.navbar-default {
+    position: sticky;
+}
 
 /* --------------------------------------------------------------------------
  * Temporaray local CSS required to make angular-ui-bootstrap