From: Bill Erickson <berick@esilibrary.com>
Date: Mon, 28 Apr 2014 20:43:05 +0000 (-0400)
Subject: docs, cleanup, minor grid item value repair
X-Git-Url: https://old-git.evergreen-ils.org/?a=commitdiff_plain;h=026bc512364b1e74fc1d89271d840b6598bb5688;p=working%2FEvergreen.git

docs, cleanup, minor grid item value repair

Signed-off-by: Bill Erickson <berick@esilibrary.com>
---

diff --git a/Open-ILS/web/js/ui/default/staff/services/grid.js b/Open-ILS/web/js/ui/default/staff/services/grid.js
index 6f444f177c..ae4e340219 100644
--- a/Open-ILS/web/js/ui/default/staff/services/grid.js
+++ b/Open-ILS/web/js/ui/default/staff/services/grid.js
@@ -847,7 +847,7 @@ angular.module('egGridMod',
 
                 if (obj === null || obj === undefined || obj === '') return '';
                 if (!idlField) return obj;
-                return $filter('egGridValueFilter')(obj, column);
+                return $filter('egGridValueFilter')(obj, idlField);
             }
         }
 
diff --git a/Open-ILS/web/js/ui/default/staff/services/printstore.js b/Open-ILS/web/js/ui/default/staff/services/printstore.js
index 495a610bd7..6dadbf35bf 100644
--- a/Open-ILS/web/js/ui/default/staff/services/printstore.js
+++ b/Open-ILS/web/js/ui/default/staff/services/printstore.js
@@ -3,18 +3,22 @@
  *
  * Dispatches print and data storage requests to the appropriate handler.
  *
- * With each request, if a connection to Hatch is established, the
- * request is relayed.  If a connection has not been attempted, an
+ * With each top-level request, if a connection to Hatch is established,
+ * the request is relayed.  If a connection has not been attempted, an
  * attempt is made then the request is handled.  If Hatch is known to be
  * inaccessible, requests are routed to local handlers.
  *
+ * Most handlers also provide direct remote and local variants to the
+ * application can decide to which to use as needed.
+ *
  * Printing is handled locally with an egPrintContainer whose contents
  * are made visible during printing using CSS print media.
  *
- * Storage requests are handled by $window.localStorage.
+ * Local storage requests are handled by $window.localStorage.
  *
- * Note that all requests return promises, since any request may be
- * subject to aschronous processing by Hatch.
+ * Note that all top-level and remote requests return promises.  All
+ * local requests return immediate values, since local requests are
+ * never asynchronous.
  *
  */
 angular.module('egCoreMod')
@@ -56,8 +60,6 @@ angular.module('egCoreMod')
 
         if (service.hatchAvailable === false) { // Hatch is closed
             msg.deferred.reject(msg);
-            //service.pending.push(msg);
-            //service.handleRequestsLocally();
 
         } else if (service.hatchAvailable === true) { // Hatch is open
             // Hatch is known to be open