From: miker <miker@dcc99617-32d9-48b4-a31d-7c20da2025e4>
Date: Fri, 2 Jan 2009 17:47:31 +0000 (+0000)
Subject: changing opensrf response codes on general pcrud failure/denial for better client... 
X-Git-Url: https://old-git.evergreen-ils.org/?a=commitdiff_plain;h=034d8186623846c7e59cd2e3c755ca1353ccb2b2;p=Evergreen.git

changing opensrf response codes on general pcrud failure/denial for better client-side handling

git-svn-id: svn://svn.open-ils.org/ILS/trunk@11723 dcc99617-32d9-48b4-a31d-7c20da2025e4
---

diff --git a/Open-ILS/src/c-apps/oils_cstore.c b/Open-ILS/src/c-apps/oils_cstore.c
index 69dc9a66c7..6fbfe793a5 100644
--- a/Open-ILS/src/c-apps/oils_cstore.c
+++ b/Open-ILS/src/c-apps/oils_cstore.c
@@ -842,7 +842,7 @@ static jsonObject* verifyUserPCRUD( osrfMethodContext* ctx ) {
         );
 
         char* m = buffer_release(msg);
-        osrfAppSessionStatus( ctx->session, OSRF_STATUS_BADREQUEST, "osrfMethodException", ctx->request, m );
+        osrfAppSessionStatus( ctx->session, OSRF_STATUS_UNAUTHORIZED, "osrfMethodException", ctx->request, m );
 
         free(m);
         jsonObjectFree(user);
@@ -883,7 +883,7 @@ static int verifyObjectPCRUD (  osrfMethodContext* ctx, const jsonObject* obj )
         );
 
         char* m = buffer_release(msg);
-        osrfAppSessionStatus( ctx->session, OSRF_STATUS_BADREQUEST, "osrfMethodException", ctx->request, m );
+        osrfAppSessionStatus( ctx->session, OSRF_STATUS_FORBIDDEN, "osrfMethodException", ctx->request, m );
 
         free(m);
 
@@ -983,7 +983,7 @@ static int verifyObjectPCRUD (  osrfMethodContext* ctx, const jsonObject* obj )
                 );
         
                 char* m = buffer_release(msg);
-                osrfAppSessionStatus( ctx->session, OSRF_STATUS_BADREQUEST, "osrfMethodException", ctx->request, m );
+                osrfAppSessionStatus( ctx->session, OSRF_STATUS_INTERNALSERVERERROR, "osrfMethodException", ctx->request, m );
         
                 free(m);
                 free(pkey_value);
@@ -1054,7 +1054,7 @@ static int verifyObjectPCRUD (  osrfMethodContext* ctx, const jsonObject* obj )
                         );
                 
                         char* m = buffer_release(msg);
-                        osrfAppSessionStatus( ctx->session, OSRF_STATUS_BADREQUEST, "osrfMethodException", ctx->request, m );
+                        osrfAppSessionStatus( ctx->session, OSRF_STATUS_INTERNALSERVERERROR, "osrfMethodException", ctx->request, m );
                         free(m);
                 
                         osrfStringArrayFree(class_list);
@@ -1493,12 +1493,12 @@ static jsonObject* doRetrieve(osrfMethodContext* ctx, int* err ) {
         growing_buffer* msg = buffer_init(128);
         buffer_fadd(
             msg,
-            "%s: Insufficient permissions",
+            "%s: Insufficient permissions to retrieve object",
             MODULENAME
         );
 
         char* m = buffer_release(msg);
-        osrfAppSessionStatus( ctx->session, OSRF_STATUS_BADREQUEST, "osrfMethodException", ctx->request, m );
+        osrfAppSessionStatus( ctx->session, OSRF_STATUS_NOTALLOWED, "osrfMethodException", ctx->request, m );
 
         free(m);