From: Jason Etheridge <jason@EquinoxOLI.org>
Date: Fri, 16 Dec 2022 12:00:28 +0000 (-0500)
Subject: allow for the explicit setting of null for certain eligible fields in fmEditor
X-Git-Url: https://old-git.evergreen-ils.org/?a=commitdiff_plain;h=03de93b916f58364abad0414d8005681eeb2d5a7;p=working%2FEvergreen.git

allow for the explicit setting of null for certain eligible fields in fmEditor
---

diff --git a/Open-ILS/src/eg2/src/app/share/fm-editor/fm-editor.component.html b/Open-ILS/src/eg2/src/app/share/fm-editor/fm-editor.component.html
index 518125ccaa..08d2f74953 100644
--- a/Open-ILS/src/eg2/src/app/share/fm-editor/fm-editor.component.html
+++ b/Open-ILS/src/eg2/src/app/share/fm-editor/fm-editor.component.html
@@ -31,6 +31,9 @@
         <div class="col-lg-3">
           <label for="{{idPrefix}}-{{field.name}}">{{field.label}}</label>
           <eg-help-popover [placement]="'right'" *ngIf="field.helpText" helpText="{{field.helpTextValue}}"></eg-help-popover>
+          <ng-container *ngIf="isSafeToNull(field)">
+            <br />(<a (click)="setToNull(field)" href='javascript:;'><span i18n>Unset</span></a>)
+          </ng-container>
         </div>
         <div class="col-lg-9">
 
diff --git a/Open-ILS/src/eg2/src/app/share/fm-editor/fm-editor.component.ts b/Open-ILS/src/eg2/src/app/share/fm-editor/fm-editor.component.ts
index 8c1f5ba6ae..504539a5b5 100644
--- a/Open-ILS/src/eg2/src/app/share/fm-editor/fm-editor.component.ts
+++ b/Open-ILS/src/eg2/src/app/share/fm-editor/fm-editor.component.ts
@@ -421,9 +421,10 @@ export class FmRecordEditorComponent
             if (field.datatype === 'bool') {
                 if (rec[field.name]() === true) {
                     rec[field.name]('t');
-                // } else if (rec[field.name]() === false) {
-                } else { // TODO: some bools can be NULL
+                } else if (rec[field.name]() === false) {
                     rec[field.name]('f');
+                } else {
+                    rec[field.name](null);
                 }
             } else if (field.datatype === 'org_unit') {
                 const org = rec[field.name]();
@@ -715,6 +716,23 @@ export class FmRecordEditorComponent
             }
         );
     }
+
+    isSafeToNull(field) {
+        if (field.datatype == 'id') {
+            return false;
+        }
+        if (field.readOnly) {
+            return false;
+        }
+        if (field.isRequired()) {
+            return false;
+        }
+        return true;
+    }
+
+    setToNull(field) {
+        this.record[field.name](null);
+    }
 }
 
 // https://stackoverflow.com/a/57812865