From: Mike Rylander Date: Sat, 21 May 2011 13:05:04 +0000 (-0400) Subject: Spacing and code comments to keep future-miker from becoming confused again by the... X-Git-Url: https://old-git.evergreen-ils.org/?a=commitdiff_plain;h=0612489eb8d325b30c4fa1bf7afa961cd9c45979;p=evergreen%2Fpines.git Spacing and code comments to keep future-miker from becoming confused again by the lack thereof Signed-off-by: Mike Rylander --- diff --git a/Open-ILS/src/perlmods/lib/OpenILS/Application/Vandelay.pm b/Open-ILS/src/perlmods/lib/OpenILS/Application/Vandelay.pm index d88e3a4d3c..9dd923e0c5 100644 --- a/Open-ILS/src/perlmods/lib/OpenILS/Application/Vandelay.pm +++ b/Open-ILS/src/perlmods/lib/OpenILS/Application/Vandelay.pm @@ -1383,6 +1383,7 @@ sub retrieve_queue_summary { if($type eq 'bib') { + # count of all items attached to records in the queue in question my $query = { select => {vii => [{alias => 'count', column => 'id', transform => 'count', aggregate => 1}]}, from => 'vii', @@ -1396,10 +1397,13 @@ sub retrieve_queue_summary { } } }; - $summary->{total_items} = $e->json_query($query)->[0]->{count}; + + # count of items we attempted to import, but errored, attached to records in the queue in question $query->{where}->{import_error} = {'!=' => undef}; $summary->{item_import_errors} = $e->json_query($query)->[0]->{count}; + + # count of items we successfully imported attached to records in the queue in question delete $query->{where}->{import_error}; $query->{where}->{import_time} = {'!=' => undef}; $summary->{total_items_imported} = $e->json_query($query)->[0]->{count};