From: Galen Charlton <gmc@equinoxOLI.org>
Date: Tue, 26 Apr 2022 21:33:18 +0000 (-0400)
Subject: LP#1970486: fix SuperCat crash on serial units with stat cats
X-Git-Url: https://old-git.evergreen-ils.org/?a=commitdiff_plain;h=0647d3bdc9c7945bdda4e80735247df631d382b3;p=Evergreen.git

LP#1970486: fix SuperCat crash on serial units with stat cats

This patch fixes a bug where retrieving a title via SuperCat (in
particular, with holdings XML) can crash of the title has a serial
unit (i.e., barcoded serial item) attached that also has a statistical
category.

To test
-------
[1] Create a title with a barcoded serial item.
[2] Attempt to fetch the title via SuperCat:

https://EGSERVER/opac/extras/supercat/retrieve/marcxml-full/record/BIBID

[3] Note that an internal server error is returned.
[4] Apply the patch and repeat step 2. This time, an XML
    document should be returned that includes the serial item
    and its stat cat.

Signed-off-by: Galen Charlton <gmc@equinoxOLI.org>
Signed-off-by: Mike Rylander <mrylander@gmail.com>
---

diff --git a/Open-ILS/src/perlmods/lib/OpenILS/Application/SuperCat.pm b/Open-ILS/src/perlmods/lib/OpenILS/Application/SuperCat.pm
index edaa48cb6e..45756ca419 100644
--- a/Open-ILS/src/perlmods/lib/OpenILS/Application/SuperCat.pm
+++ b/Open-ILS/src/perlmods/lib/OpenILS/Application/SuperCat.pm
@@ -2399,6 +2399,7 @@ sub new_record_holdings {
                     sstr    => [qw/items/],
                     sitem   => [qw/notes unit/],
                     sunit   => [qw/notes location status circ_lib stat_cat_entries call_number/],
+                    asce    => [qw/stat_cat/],
                     acn => [qw/owning_lib prefix suffix/],
                 },
           ( $limit > -1 ? ( limit  => $limit  ) : () ),