From: Dan Wells <dbw2@calvin.edu>
Date: Tue, 17 Feb 2015 17:31:44 +0000 (-0500)
Subject: LP#1198465 Put penalty generation in the same xact
X-Git-Url: https://old-git.evergreen-ils.org/?a=commitdiff_plain;h=07319b0d893355574479d475617b533aa08c0071;p=working%2FEvergreen.git

LP#1198465 Put penalty generation in the same xact

The penalties need to "see" any fines we may have just added, so they
need to happen in the same transaction.  Passing in the optional editor
makes this an easy fix.

Signed-off-by: Dan Wells <dbw2@calvin.edu>
---

diff --git a/Open-ILS/src/perlmods/lib/OpenILS/Application/Circ/CircCommon.pm b/Open-ILS/src/perlmods/lib/OpenILS/Application/Circ/CircCommon.pm
index 9be2fd7032..db82c491ff 100644
--- a/Open-ILS/src/perlmods/lib/OpenILS/Application/Circ/CircCommon.pm
+++ b/Open-ILS/src/perlmods/lib/OpenILS/Application/Circ/CircCommon.pm
@@ -571,9 +571,9 @@ sub generate_fines {
 
 #            $self->method_lookup('open-ils.storage.transaction.commit')->run;
 
-            # Caluclate penalties inline
+            # Calculate penalties inline
             OpenILS::Utils::Penalty->calculate_penalties(
-                undef, $c->usr, $c->$circ_lib_method);
+                $e, $c->usr, $c->$circ_lib_method);
 
         };