From: Dan Scott <dan@coffeecode.net>
Date: Mon, 6 Jun 2011 17:38:17 +0000 (-0400)
Subject: Make copy status visibility match default config.copy_status settings
X-Git-Url: https://old-git.evergreen-ils.org/?a=commitdiff_plain;h=081b2a5ce30d9a4582d845d191b11b6c09fd25e5;p=evergreen%2Ftadl.git

Make copy status visibility match default config.copy_status settings

Previous version of this patch had hardcoded copy status settings to
0, 7, 12 to match the "Available" settings, rather than the OPAC
visibility settings available from config.copy_status for each status.

Until config.copy_status.opac_visible translates into an opac_visible
attribute on the status element in the holdings XML, this is probably
the best we can do.

Signed-off-by: Dan Scott <dscott@laurentian.ca>
---

diff --git a/Open-ILS/web/opac/skin/default/xml/result/result_table.xml b/Open-ILS/web/opac/skin/default/xml/result/result_table.xml
index 517ce19315..8838a802a5 100644
--- a/Open-ILS/web/opac/skin/default/xml/result/result_table.xml
+++ b/Open-ILS/web/opac/skin/default/xml/result/result_table.xml
@@ -166,14 +166,24 @@
                                                 return;
                                             }
 
-                                            /* Hardcoded check for copy status 0, 7, or 12 */
+                                            /* 
+                                               Hardcoded check for copy statuses per default opac_visible
+                                               setting in config.copy_status; replace with a copy attribute
+                                               check for visible status if holdings_xml ever gets that
+                                            */
                                             var ident;
                                             dojo.query('status', cp).forEach(function (status) {
                                                 ident = status.getAttribute('ident');
                                             });
-                                            if (parseInt(ident) !== 0 && 
-                                                parseInt(ident) != 7 &&
-                                                parseInt(ident) != 12) {
+                                            if (parseInt(ident) !== 0 && /* Available */
+                                                parseInt(ident) != 1 &&  /* Checked out */
+                                                parseInt(ident) != 5 &&  /* In process */
+                                                parseInt(ident) != 6 &&  /* In transit */
+                                                parseInt(ident) != 7 &&  /* Reshelving */
+                                                parseInt(ident) != 8 &&  /* On holds shelf */
+                                                parseInt(ident) != 9 &&  /* On order */
+                                                parseInt(ident) != 12
+                                            ) {
                                                 return;
                                             }