From: Dan Wells <dbw2@calvin.edu>
Date: Wed, 26 Feb 2014 22:49:49 +0000 (-0500)
Subject: LP 1198465: Move overdue restore above lost void/adjustment
X-Git-Url: https://old-git.evergreen-ils.org/?a=commitdiff_plain;h=08591c75a788f55875e1c3b7a16abe2aa853f3b5;p=working%2FEvergreen.git

LP 1198465: Move overdue restore above lost void/adjustment

If a person loses something and has their overdues adjusted to zero,
then pays for part of it, then returns the item, the part they
actually paid should apply to the overdues.  In order for this to
happen, the overdues must exist *before* the lost fines are adjusted.

Signed-off-by: Dan Wells <dbw2@calvin.edu>
---

diff --git a/Open-ILS/src/perlmods/lib/OpenILS/Application/Circ/Circulate.pm b/Open-ILS/src/perlmods/lib/OpenILS/Application/Circ/Circulate.pm
index 9e1d018e9f..9a0b3d7ae8 100644
--- a/Open-ILS/src/perlmods/lib/OpenILS/Application/Circ/Circulate.pm
+++ b/Open-ILS/src/perlmods/lib/OpenILS/Application/Circ/Circulate.pm
@@ -3591,12 +3591,12 @@ sub checkin_handle_lost_or_longoverdue {
                     $self->editor);
         }
 
+        $self->checkin_handle_lost_or_lo_now_found_restore_od($circ_lib) 
+            if $restore_od && ! $self->void_overdues;
         $self->checkin_handle_lost_or_lo_now_found(
             $args{void_cost_btype}, $args{is_longoverdue}) if $void_cost;
         $self->checkin_handle_lost_or_lo_now_found(
             $args{void_fee_btype}, $args{is_longoverdue}) if $void_proc_fee;
-        $self->checkin_handle_lost_or_lo_now_found_restore_od($circ_lib) 
-            if $restore_od && ! $self->void_overdues;
     }
 
     if ($circ_lib != $self->circ_lib) {