From: Mike Rylander <mrylander@gmail.com>
Date: Fri, 17 Jan 2014 23:55:26 +0000 (-0500)
Subject: Need to distinguish between controlled and uncontrolled attributes when finding value IDs
X-Git-Url: https://old-git.evergreen-ils.org/?a=commitdiff_plain;h=0daca55f54aacea34acf78cde378d2c49b165bf5;p=working%2FEvergreen.git

Need to distinguish between controlled and uncontrolled attributes when finding value IDs

Signed-off-by: Mike Rylander <mrylander@gmail.com>
---

diff --git a/Open-ILS/src/perlmods/lib/OpenILS/Application/Storage/Driver/Pg/QueryParser.pm b/Open-ILS/src/perlmods/lib/OpenILS/Application/Storage/Driver/Pg/QueryParser.pm
index 997c94f1b6..147b16571e 100644
--- a/Open-ILS/src/perlmods/lib/OpenILS/Application/Storage/Driver/Pg/QueryParser.pm
+++ b/Open-ILS/src/perlmods/lib/OpenILS/Application/Storage/Driver/Pg/QueryParser.pm
@@ -713,8 +713,10 @@ sub dynamic_filter_compile {
 
     my $method = $_dfilter_controlled_cache{$filter}{controlled} ?
         'search_config_coded_value_map' : 'search_metabib_uncontrolled_record_attr_value';
-    my $match_field = $_dfilter_controlled_cache{$filter}{controlled} ?
+    my $attr_field = $_dfilter_controlled_cache{$filter}{controlled} ?
         'ctype' : 'attr';
+    my $value_field = $_dfilter_controlled_cache{$filter}{controlled} ?
+        'code' : 'value';
 
     return sprintf('%s(%s)', $negate,
         join(
@@ -722,7 +724,7 @@ sub dynamic_filter_compile {
             map {
                 $_->id
             } @{
-                $e->$method({ $match_field => $filter, code => $params })
+                $e->$method({ $attr_field => $filter, $value_field => $params })
             }
         )
     );