From: James Fournie <jfournie@sitka.bclibraries.ca>
Date: Tue, 18 Dec 2012 20:45:51 +0000 (-0800)
Subject: Check for a selection_depth returned from title_hold.is_possible.
X-Git-Url: https://old-git.evergreen-ils.org/?a=commitdiff_plain;h=0f4f8d00092b6f9c1377c7353c3eb98e767061b9;p=evergreen%2Fmasslnc.git

Check for a selection_depth returned from title_hold.is_possible.
See Launchpad 1064651 for details.  This is a quick fix which solves a
fairly serious issue whereby copies outside of a hard boundary could fill
holds when they are placed within the TPAC in the staff client.

Signed-off-by: James Fournie <jfournie@sitka.bclibraries.ca>
Signed-off-by: Jason Stephenson <jstephenson@mvlc.org>
---

diff --git a/Open-ILS/src/perlmods/lib/OpenILS/Application/Circ/Holds.pm b/Open-ILS/src/perlmods/lib/OpenILS/Application/Circ/Holds.pm
index 0b188bf2e2..d713fd32ac 100644
--- a/Open-ILS/src/perlmods/lib/OpenILS/Application/Circ/Holds.pm
+++ b/Open-ILS/src/perlmods/lib/OpenILS/Application/Circ/Holds.pm
@@ -93,6 +93,9 @@ sub test_and_create_hold_batch {
         ($res) = $self->method_lookup(
             'open-ils.circ.title_hold.is_possible')->run($auth, $params, $override ? $oargs : {});
         if ($res->{'success'} == 1) {
+
+            $params->{'depth'} = $res->{'depth'} if $res->{'depth'};
+
             my $ahr = construct_hold_request_object($params);
             my ($res2) = $self->method_lookup(
                 $override