From: Mike Rylander <mrylander@gmail.com>
Date: Thu, 4 Aug 2016 13:39:45 +0000 (-0400)
Subject: Proper lookup of user setting values
X-Git-Url: https://old-git.evergreen-ils.org/?a=commitdiff_plain;h=128b8a250ef80034282d9ee888ae8c76a64ad113;p=working%2FEvergreen.git

Proper lookup of user setting values

Signed-off-by: Mike Rylander <mrylander@gmail.com>
---

diff --git a/Open-ILS/web/js/ui/default/staff/circ/patron/checkout.js b/Open-ILS/web/js/ui/default/staff/circ/patron/checkout.js
index d336d7004a..04110aa737 100644
--- a/Open-ILS/web/js/ui/default/staff/circ/patron/checkout.js
+++ b/Open-ILS/web/js/ui/default/staff/circ/patron/checkout.js
@@ -34,12 +34,21 @@ function($scope , $q , $routeParams , egCore , egUser , patronSvc ,
         );
     }
 
+    function setting_value (user, setting) {
+        if (user) {
+            var list = user.settings().filter(function(s){
+                return s.name() == setting;
+            });
+
+            if (list.length) return list[0].value();
+        }
+    }
+
     $scope.email_receipt = function() {
-        return  (
-            patronSvc.current &&
-            patronSvc.current.settings()['circ.send_email_checkout_receipts'] &&
-            patronSvc.current.settings()['circ.send_email_checkout_receipts'] == 'true'
-        );
+        return setting_value(
+            patronSvc.current,
+            'circ.send_email_checkout_receipts'
+        ) == 'true';
     }
 
     $scope.using_hatch = egCore.hatch.usingHatch();