From: Bill Erickson <berickxx@gmail.com>
Date: Mon, 22 Jun 2015 16:01:19 +0000 (-0400)
Subject: LP#1465847 Empty patron search exits early
X-Git-Tag: sprint4-merge-nov22~1056
X-Git-Url: https://old-git.evergreen-ils.org/?a=commitdiff_plain;h=12a3f5bfaeaae1f6a5b59177f417041088841a49;p=working%2FEvergreen.git

LP#1465847 Empty patron search exits early

If no search parameters or invalid search parameters are sent to the
patron search API, the API call exits early with zero results.  This
avoids cases where empty searches can lead to heavy DB calls, querying
and sorting he entire patron data set.

Signed-off-by: Bill Erickson <berickxx@gmail.com>
Signed-off-by: Jason Stephenson <jstephenson@mvlc.org>
---

diff --git a/Open-ILS/src/perlmods/lib/OpenILS/Application/Actor.pm b/Open-ILS/src/perlmods/lib/OpenILS/Application/Actor.pm
index bdc78da721..fcc71a52f4 100644
--- a/Open-ILS/src/perlmods/lib/OpenILS/Application/Actor.pm
+++ b/Open-ILS/src/perlmods/lib/OpenILS/Application/Actor.pm
@@ -1348,6 +1348,19 @@ sub patron_adv_search {
     my( $self, $client, $auth, $search_hash, $search_limit, 
         $search_sort, $include_inactive, $search_ou, $flesh_fields, $offset) = @_;
 
+    # API params sanity checks.
+    # Exit early with empty result if no filter exists.
+    # .fleshed call is streaming.  Non-fleshed is effectively atomic.
+    my $fleshed = ($self->api_name =~ /fleshed/);
+    return ($fleshed ? undef : []) unless (ref $search_hash ||'') eq 'HASH';
+    my $search_ok = 0;
+    for my $key (keys %$search_hash) {
+        next if $search_hash->{$key}{value} =~ /^\s*$/; # empty filter
+        $search_ok = 1;
+        last;
+    }
+    return ($fleshed ? undef : []) unless $search_ok;
+
     my $e = new_editor(authtoken=>$auth);
     return $e->event unless $e->checkauth;
     return $e->event unless $e->allowed('VIEW_USER');