From: Jason Boyer Date: Fri, 31 Jul 2020 15:10:24 +0000 (-0400) Subject: LP1842431: Remove redundant description field X-Git-Url: https://old-git.evergreen-ils.org/?a=commitdiff_plain;h=13c3771e3ce7fb23ce93a6943553d13519a2303d;p=evergreen%2Ftadl.git LP1842431: Remove redundant description field This branch brings about a good change, but I think having reason and description be identical in the case of a failure and blank / 'SUCCESS' in the case of, well, success, is redundant and potentially confusing. Also, if it's not used in the default template I doubt anyone ever realizes it's there. :) Template editors can use is_renewed to decide if they want to display success as a result and that way the capitalization won't look like THE EIGHTIES have come back in fashion again. :D Signed-off-by: Jason Boyer Signed-off-by: Jason Stephenson --- diff --git a/Open-ILS/src/perlmods/lib/OpenILS/Application/Trigger/Reactor/Circ/AutoRenew.pm b/Open-ILS/src/perlmods/lib/OpenILS/Application/Trigger/Reactor/Circ/AutoRenew.pm index 0fbc21dffd..a64d19cb6d 100644 --- a/Open-ILS/src/perlmods/lib/OpenILS/Application/Trigger/Reactor/Circ/AutoRenew.pm +++ b/Open-ILS/src/perlmods/lib/OpenILS/Application/Trigger/Reactor/Circ/AutoRenew.pm @@ -74,7 +74,6 @@ sub handler { new_due_date => $is_renewed ? $evt->{payload}->{circ}->due_date : '', old_due_date => !$is_renewed ? $_->due_date() : '', textcode => $evt->{textcode}, - description => $evt->{desc}, ); # Create the event from the source circ instead of the