From: Bill Erickson <berickxx@gmail.com>
Date: Wed, 27 Mar 2019 16:43:32 +0000 (-0400)
Subject: Coerce numbers for bib IDs in Angular staff catalog
X-Git-Url: https://old-git.evergreen-ils.org/?a=commitdiff_plain;h=1522d95ec18dec4fb562df8b29c2437a8faac5a0;p=evergreen%2Fequinox.git

Coerce numbers for bib IDs in Angular staff catalog

Under some circumstances, the search results screen in the new
experimental Angular staff catalog did not display any results (though
it did show the pager, facets, etc.).

This was traced back to the results array attempting to be populated
with ID values of '-1' instead of the real IDs.  Coercing the incoming
IDs to numbers appears to resolve the issue.

Signed-off-by: Bill Erickson <berickxx@gmail.com>
Signed-off-by: Dan Wells <dbw2@calvin.edu>
---

diff --git a/Open-ILS/src/eg2/src/app/share/catalog/bib-record.service.ts b/Open-ILS/src/eg2/src/app/share/catalog/bib-record.service.ts
index d536c8beb5..b2058e7aed 100644
--- a/Open-ILS/src/eg2/src/app/share/catalog/bib-record.service.ts
+++ b/Open-ILS/src/eg2/src/app/share/catalog/bib-record.service.ts
@@ -33,7 +33,7 @@ export class BibRecordSummary {
     net: NetService;
 
     constructor(record: IdlObject, orgId: number, orgDepth: number) {
-        this.id = record.id();
+        this.id = Number(record.id());
         this.record = record;
         this.orgId = orgId;
         this.orgDepth = orgDepth;
@@ -221,7 +221,7 @@ export class BibRecordService {
         // Reconsider this approach (see also note above about API).
         this.getBibSummary(metabib.master_record(), orgId, orgDepth)
         .subscribe(summary => {
-            summary.metabibId = metabib.id();
+            summary.metabibId = Number(metabib.id());
             summary.metabibRecords =
                 metabib.source_maps().map(m => Number(m.source()));
 
diff --git a/Open-ILS/src/eg2/src/app/share/catalog/search-context.ts b/Open-ILS/src/eg2/src/app/share/catalog/search-context.ts
index 7e5f8109e6..f18a8cde2d 100644
--- a/Open-ILS/src/eg2/src/app/share/catalog/search-context.ts
+++ b/Open-ILS/src/eg2/src/app/share/catalog/search-context.ts
@@ -276,7 +276,7 @@ export class CatalogSearchContext {
     }
 
     addResultId(id: number, resultIdx: number ): void {
-        this.resultIds[resultIdx + this.pager.offset] = id;
+        this.resultIds[resultIdx + this.pager.offset] = Number(id);
     }
 
     // Return the record at the requested index.