From: Bill Erickson <berick@esilibrary.com>
Date: Mon, 30 Dec 2013 20:36:53 +0000 (-0500)
Subject: LP#1268636 advanced search repairs
X-Git-Tag: sprint4-merge-nov22~2357
X-Git-Url: https://old-git.evergreen-ils.org/?a=commitdiff_plain;h=161815ed45e1eb468ddf342af25cf64b1bd80a94;p=working%2FEvergreen.git

LP#1268636 advanced search repairs

* avoid dupe IDs
* removes extraneous <div>'s
* clean up attrs w/ preceding spaces

Signed-off-by: Bill Erickson <berick@esilibrary.com>
Signed-off-by: Dan Scott <dscott@laurentian.ca>
---

diff --git a/Open-ILS/src/templates/opac/css/style.css.tt2 b/Open-ILS/src/templates/opac/css/style.css.tt2
index 5716495c69..3beb4ee26f 100644
--- a/Open-ILS/src/templates/opac/css/style.css.tt2
+++ b/Open-ILS/src/templates/opac/css/style.css.tt2
@@ -286,12 +286,12 @@ div.select-box-wrapper {
 #adv_search_rows {
     border-bottom: none;
 }
-#adv_filter_block {
+.adv_filter_block {
     padding: 15px;
     float: left;
-    clear: both;
+    /*clear: both;*/
 }
-#adv_filter_block_item {
+.adv_filter_block_item {
     float: left;
     padding: 5px;
 }
diff --git a/Open-ILS/src/templates/opac/parts/advanced/global_row.tt2 b/Open-ILS/src/templates/opac/parts/advanced/global_row.tt2
index 5ce4305f0e..4d9ff4f379 100644
--- a/Open-ILS/src/templates/opac/parts/advanced/global_row.tt2
+++ b/Open-ILS/src/templates/opac/parts/advanced/global_row.tt2
@@ -46,7 +46,10 @@
         <input type='text' size='18' name='query' value="[% q | html %]" x-webkit-speech [% IF loop.index == 0 %] autofocus [% END %] />
         <a href="javascript:;" class="row-remover"
             title="[% l('Remove row') %]" alt="[% l('Remove row') %]"
-            onclick='return killRowIfAtLeast(2, this);'><img src="[% ctx.media_prefix %]/images/adv_row_close_btn.png" /></a>
+            onclick='return killRowIfAtLeast(2, this);'>
+                <img src="[% ctx.media_prefix %]/images/adv_row_close_btn.png" 
+                    alt="[% l('Remove row') %]"/>
+            </a>
     </td>
 </tr>
 [% END %]
diff --git a/Open-ILS/src/templates/opac/parts/advanced/search.tt2 b/Open-ILS/src/templates/opac/parts/advanced/search.tt2
index 42e5cfcebd..d5a663f517 100644
--- a/Open-ILS/src/templates/opac/parts/advanced/search.tt2
+++ b/Open-ILS/src/templates/opac/parts/advanced/search.tt2
@@ -35,7 +35,8 @@
         <span>
             <input id='search-submit-go' type="submit" value="[% l('Search') %]" alt="[% l('Search') %]" class="opac-button"
                 onclick='setTimeout(function(){$("search-submit-spinner").className=""; $("search-submit-go").className="hidden"}, 2000)'/>
-            <img id='search-submit-spinner' src='/opac/images/progressbar_green.gif' class='hidden' alt=''/>
+            <img id='search-submit-spinner' src='/opac/images/progressbar_green.gif' 
+                class='hidden' alt="[% l('Search in progress icon') %]"/>
         </span>
 
         <a href="[% mkurl(ctx.opac_root _ '/advanced', {$loc_name => loc_value}, 1) %]"
@@ -51,10 +52,10 @@
         NEXT IF adv_chunk.adv_hide;
         IF in_row == 0;
             in_row = 1; %]
-            <div id='adv_filter_block'>
+            <div class='adv_filter_block'>
 [%
         END; %]
-            <div id='adv_filter_block_item'>
+            <div class='adv_filter_block_item'>
             <div valign='top'[% IF adv_chunk.js_only %]
                 id='adv_chunk_[% adv_chunk.adv_special %]'
                 class='hidden'[% END %]>
@@ -74,8 +75,8 @@
                             </div>
 [%
                 CASE "pub_year"; %]
-                            <select name='pubdate' onchange='
-                                if(this.selectedIndex == 3)
+                            <select name='pubdate' 
+                                onchange='if(this.selectedIndex == 3)
                                     unHideMe($("adv_global_pub_date_2_span"));
                                 else
                                     hideMe($("adv_global_pub_date_2_span"));'>
@@ -123,7 +124,6 @@
         END;
     END; %]
 
-            </div>
         </div>
     </div>
 </div>