From: Bill Erickson <berickxx@gmail.com>
Date: Fri, 29 Apr 2016 18:37:25 +0000 (-0400)
Subject: JBAS-1132 (etc.) Avoid data inserts on new DB builds
X-Git-Url: https://old-git.evergreen-ils.org/?a=commitdiff_plain;h=16b3eff376b5f6dc31c8ad0cbe73633f61d56e77;p=working%2FEvergreen.git

JBAS-1132 (etc.) Avoid data inserts on new DB builds

Repair some Sqitch SQL scripts so they don't insert or verify on data
that should not exist yet.

Signed-off-by: Bill Erickson <berickxx@gmail.com>
---

diff --git a/KCLS/sql/schema/deploy/sip-activity-types.sql b/KCLS/sql/schema/deploy/sip-activity-types.sql
index 517e0710b9..5b152dbf0f 100644
--- a/KCLS/sql/schema/deploy/sip-activity-types.sql
+++ b/KCLS/sql/schema/deploy/sip-activity-types.sql
@@ -3,13 +3,20 @@
 
 BEGIN;
 
-INSERT INTO config.usr_activity_type 
-    (ewho, ewhat, ehow, label, egroup, enabled, transient)
-VALUES
-    ('lyndasip', 'verify', 'sip2', 
-        'Lynda.com User Verification (via SIP)', 'authz', TRUE, FALSE),
-    ('hooplasip2', 'verify', 'sip2', 
-        'Hoopla User Verification (via SIP)', 'authz', TRUE, FALSE);
+-- Test inserted data if needed
+DO $$
+BEGIN
+    IF evergreen.insert_on_deploy() THEN
+        INSERT INTO config.usr_activity_type 
+            (ewho, ewhat, ehow, label, egroup, enabled, transient)
+        VALUES
+            ('lyndasip', 'verify', 'sip2', 
+                'Lynda.com User Verification (via SIP)', 'authz', TRUE, FALSE),
+            ('hooplasip2', 'verify', 'sip2', 
+                'Hoopla User Verification (via SIP)', 'authz', TRUE, FALSE);
+    END IF;
+
+END $$;
 
 COMMIT;
 
diff --git a/KCLS/sql/schema/verify/patron-self-reg-mods.sql b/KCLS/sql/schema/verify/patron-self-reg-mods.sql
index 9924852f66..96e9e3d2fc 100644
--- a/KCLS/sql/schema/verify/patron-self-reg-mods.sql
+++ b/KCLS/sql/schema/verify/patron-self-reg-mods.sql
@@ -2,17 +2,16 @@
 
 BEGIN;
 
--- XXX Add verifications here.
-
-SELECT 1 / COUNT(*) FROM config.org_unit_setting_type 
-    WHERE name = 'opac.self_register.profile'; 
-
 SELECT ident_value2 FROM staging.user_stage LIMIT 1;
 
 -- Test inserted data if needed
 DO $$
 BEGIN
     IF evergreen.insert_on_deploy() THEN
+
+        PERFORM 1 / COUNT(*) FROM config.org_unit_setting_type 
+            WHERE name = 'opac.self_register.profile'; 
+
         PERFORM 1 / COUNT(*) FROM actor.org_unit_setting
             WHERE name = 'opac.self_register.profile';