From: dbs <dbs@dcc99617-32d9-48b4-a31d-7c20da2025e4>
Date: Sat, 9 May 2009 18:25:10 +0000 (+0000)
Subject: Invoke escape() as a function rather than method, avoids returning 1 for any input
X-Git-Url: https://old-git.evergreen-ils.org/?a=commitdiff_plain;h=16ed8ce27f7432e36d8b5f4408adf73ef09fe5b4;p=Evergreen.git

Invoke escape() as a function rather than method, avoids returning 1 for any input

This is not ideal but solves the problem in the short-term.


git-svn-id: svn://svn.open-ils.org/ILS/trunk@13113 dcc99617-32d9-48b4-a31d-7c20da2025e4
---

diff --git a/Open-ILS/src/perlmods/OpenILS/Application/SuperCat.pm b/Open-ILS/src/perlmods/OpenILS/Application/SuperCat.pm
index 7f0bbcf1ed..3592f81919 100644
--- a/Open-ILS/src/perlmods/OpenILS/Application/SuperCat.pm
+++ b/Open-ILS/src/perlmods/OpenILS/Application/SuperCat.pm
@@ -891,11 +891,11 @@ sub basic_record_holdings {
 			next unless grep { $cp->circ_lib->id == $_ } @ou_ids;
 			next unless ( $cp->deleted eq 'f' || $cp->deleted == 0 );
 
-
-			my $cp_stat = $self->escape($cp->status->name);
-			my $cp_loc = $self->escape($cp->location->name);
-			my $cp_lib = $self->escape($cp->circ_lib->shortname);
-			my $cp_bc = $self->escape($cp->barcode);
+			# Ugly, but avoids (for now) returning 1 for each of these
+			my $cp_stat = escape($self, $cp->status->name);
+			my $cp_loc = escape($self, $cp->location->name);
+			my $cp_lib = escape($self, $cp->circ_lib->shortname);
+			my $cp_bc = escape($self, $cp->barcode);
 
 			push @{$holdings{$cn->label}{'copies'}}, { barcode => $cp_bc, status => $cp_stat, location => $cp_loc, circlib => $cp_lib};