From: phasefx <phasefx@dcc99617-32d9-48b4-a31d-7c20da2025e4>
Date: Tue, 23 Jun 2009 12:59:20 +0000 (+0000)
Subject: the middle layer lets staff change the pickup lib of a hold already on the holds... 
X-Git-Tag: sprint4-merge-nov22~9782
X-Git-Url: https://old-git.evergreen-ils.org/?a=commitdiff_plain;h=1702fa5b76563055a03abe33eeb8ea339c9958c1;p=working%2FEvergreen.git

the middle layer lets staff change the pickup lib of a hold already on the holds shelf if they have the UPDATE_PICKUP_LIB_FROM_HOLDS_SHELF permission.  It'll create a new transit.  So let the staff client allow it too

git-svn-id: svn://svn.open-ils.org/ILS/trunk@13436 dcc99617-32d9-48b4-a31d-7c20da2025e4
---

diff --git a/Open-ILS/xul/staff_client/server/patron/holds.js b/Open-ILS/xul/staff_client/server/patron/holds.js
index 41faa754cb..bfb75a45ce 100644
--- a/Open-ILS/xul/staff_client/server/patron/holds.js
+++ b/Open-ILS/xul/staff_client/server/patron/holds.js
@@ -332,7 +332,7 @@ patron.holds.prototype = {
                                 var deny_edit_because_of_transit = false;
                                 for (var i = 0; i < obj.retrieve_ids.length; i++) {
                                     var hold = obj.holds_map[ obj.retrieve_ids[i].id ];
-                                    if (hold.status() > 2 /* Which means holds that are In-Transit or Ready for Pickup */) deny_edit_because_of_transit = true;
+                                    if (hold.status() == 3 /* In-Transit */) deny_edit_because_of_transit = true;
                                 }
                                 if (deny_edit_because_of_transit) {
                                     alert(document.getElementById('circStrings').getString('staff.circ.holds.error.may_not_edit_pickup_lib_for_hold_intransit'));