From: Galen Charlton <gmc@esilibrary.com>
Date: Thu, 5 Jun 2014 22:16:23 +0000 (-0700)
Subject: LP#1326983: excluded fulfilled holds when adding hold_request.shelf_expires_soon... 
X-Git-Url: https://old-git.evergreen-ils.org/?a=commitdiff_plain;h=1a9e623ab0d0b841961afaa0a9810a24b8e98f19;p=evergreen%2Fpines.git

LP#1326983: excluded fulfilled holds when adding hold_request.shelf_expires_soon events

This patch adjusts the example A/T filter for the
hold_request.shelf_expires_soon hook to exclude hold requests that are
already marked as fulfilled.  This saves time creating events that
would immediately be marked as invalid per the HoldIsAvailable
validator.

It also addresses an issue for large databases that have lots of
fulfilled holds wherein hold_request.shelf_expires_soon events can
fail to be added at all due to a cstore timeout.

Signed-off-by: Galen Charlton <gmc@esilibrary.com>
Signed-off-by: Ben Shum <bshum@biblio.org>
---

diff --git a/Open-ILS/examples/action_trigger_filters.json.example b/Open-ILS/examples/action_trigger_filters.json.example
index 31d713d79b..d24759d157 100644
--- a/Open-ILS/examples/action_trigger_filters.json.example
+++ b/Open-ILS/examples/action_trigger_filters.json.example
@@ -16,7 +16,8 @@
             "capture_time": {"!=": null},
             "current_copy": {"!=": null},
             "shelf_time": {"!=": null},
-            "cancel_time": null
+            "cancel_time": null,
+            "fulfillment_time": null
         }
     },
     "hold_request.long_wait" : {