From: Dan Scott Date: Fri, 21 Jun 2013 03:11:20 +0000 (-0400) Subject: Silence uninit var warnings from query normalizer X-Git-Url: https://old-git.evergreen-ils.org/?a=commitdiff_plain;h=1bb05b3732643ddbbc0a4ca4ef1553ef44749fc0;p=contrib%2FConifer.git Silence uninit var warnings from query normalizer $field_info can return undef from the search for a matching ID from the list of normalizers, which in turn generates several uninit var warnings when attempts are made to access members of the undef variable. We saw 6700 occurrences of these warnings during a typical day of operations. Signed-off-by: Dan Scott --- diff --git a/Open-ILS/src/perlmods/lib/OpenILS/Application/Storage/Driver/Pg/QueryParser.pm b/Open-ILS/src/perlmods/lib/OpenILS/Application/Storage/Driver/Pg/QueryParser.pm index f50ab0bebe..431e26f38b 100644 --- a/Open-ILS/src/perlmods/lib/OpenILS/Application/Storage/Driver/Pg/QueryParser.pm +++ b/Open-ILS/src/perlmods/lib/OpenILS/Application/Storage/Driver/Pg/QueryParser.pm @@ -415,6 +415,7 @@ sub initialize_query_normalizers { for my $cmfinm ( @$tree ) { my $field_info = $self->search_field_class_by_id( $cmfinm->field ); + next unless $field_info; __PACKAGE__->add_query_normalizer( $field_info->{classname}, $field_info->{field}, $cmfinm->norm->func, OpenSRF::Utils::JSON->JSON2perl($cmfinm->params) ); } }