From: erickson <erickson@dcc99617-32d9-48b4-a31d-7c20da2025e4>
Date: Thu, 14 Dec 2006 14:24:45 +0000 (+0000)
Subject: fixed a broken order_by statement and cleaned up a boolean test
X-Git-Url: https://old-git.evergreen-ils.org/?a=commitdiff_plain;h=201b6058561bca3ebc0f7fa99b74aef50896ea40;p=evergreen%2Fpines.git

fixed a broken order_by statement and cleaned up a boolean test


git-svn-id: svn://svn.open-ils.org/ILS/trunk@6704 dcc99617-32d9-48b4-a31d-7c20da2025e4
---

diff --git a/Open-ILS/src/perlmods/OpenILS/Application/Circ/Holds.pm b/Open-ILS/src/perlmods/OpenILS/Application/Circ/Holds.pm
index d9d2f83ec3..58890b1d55 100644
--- a/Open-ILS/src/perlmods/OpenILS/Application/Circ/Holds.pm
+++ b/Open-ILS/src/perlmods/OpenILS/Application/Circ/Holds.pm
@@ -831,7 +831,7 @@ sub flesh_hold_notices {
 		my $notices = $e->search_action_hold_notification(
 			[
 				{ hold => $hold->id },
-				{ order_by => { anh => { 'notify_time desc' } } },
+				{ order_by => { anh => 'notify_time desc' } },
 			],
 			{idlist=>1}
 		);
@@ -944,9 +944,7 @@ sub check_title_hold {
 			$e->allowed('VIEW_HOLD_PERMIT', $patron->home_ou);
 	}
 
-	return OpenILS::Event->new('PATRON_BARRED') 
-		if $patron->barred and 
-			($patron->barred =~ /t/i or $patron->barred == 1);
+	return OpenILS::Event->new('PATRON_BARRED') if $U->is_true($patron->barred);
 
 	my $rangelib	= $params{range_lib} || $patron->home_ou;